517398 - stop using the Mac OS Scrap Manager API in 64-bit builds

Status: RESOLVED FIXED

(Core :: Find Backend, defect)

Description

[Josh Aas]

We need to stop using the Mac OS Scrap Manager API. It's old and not available for 64-bit applications. We use it in places like "nsWebBrowserFind.cpp".

Comment 1

[Josh Aas]

Attachment: fix v1.0

This will work for right now. We can file another bug on doing this a better way for 64-bit applications, but I don't remember this ever working for 32-bit applications anyway.

Comment 2

[Benjamin Smedberg]

Comment on attachment 401377 [details] [diff] [review]
fix v1.0

Do you understand what this code is doing at all? It looks pointless and should just be removed.

Comment 3

[Josh Aas]

Mac OS X has a search clipboard, to sync find strings across applications. The code is attempting to use the string from the find clipboard as the search string, and when the user enters a new string it puts the new string on the find clipboard.

Comment 4

[Jonathan Kew [:jfkthame]]

(In reply to comment #1)

> I don't remember this ever working for 32-bit
> applications anyway.

It seems to partially work, at least, in FF 3.5: if I type a string into the Find bar in Firefox, and then go to TextEdit.app and bring up the Find panel there, my same string appears.

Doesn't seem to work in the other direction, though. I haven't tried to debug why that is.

Comment 5

[Josh Aas]

In any case, I just want a compile fix. We should file a bug on investigating but such issues are totally separate from this tiny compile fix.

Comment 6

[Josh Aas]

Comment on attachment 401377 [details] [diff] [review]
fix v1.0

Re-requesting review because this code is still used in 32-bit builds. See comment #3 for an explanation of what it does. We can file another bug on implementing that for 64-bit and improving the 32-bit implementation.

Comment 7

[Benjamin Smedberg]

Comment on attachment 401377 [details] [diff] [review]
fix v1.0

Gah, please do make sure a followup is filed: this is not the right place to have this code.

Comment 8

[Josh Aas]

pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/81c9a9f7ac72

Comment 9

[Josh Aas]

Filed bug 518660 about the Scrap Manager API usage.