Closed Bug 517412 Opened 13 years ago Closed 13 years ago

nsLookAndFeel.mm fails to compile 64-bit

Categories

(Core :: Widget: Cocoa, defect)

x86_64
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: jaas, Assigned: mstange)

References

()

Details

Attachments

(2 files, 4 obsolete files)

nsLookAndFeel.mm fails to compile 64-bit. Problematic API usage:

::GetThemeBrushAsColor
::GetThemeTextColor
::GetThemeAccentColors
::GetThemeScrollBarArrowStyle
::GetThemeScrollBarThumbStyle
Attached file comparison testcase (obsolete) —
Attached file comparison testcase
Attachment #402024 - Attachment is obsolete: true
Attached patch v1 (obsolete) — Splinter Review
This is really no fun at all. Most of those color names don't make sense on OS X, so I've either tried to find a matching NSColor color or hardcoded it to the traditional value. Moreover, many of these colors are completely unused and could be removed, but I don't want to do that in this bug. (Actually I don't want to do it at all, since it's really tedious work...)

The only colors that the user can influence are "system appeararance" color and the selection color. I've explicitly made sure that we respond to those colors correctly.

The "accent" colors that I'm removing were used for pre-Aqua metal scrollbars. We don't need them any more.
Attachment #402030 - Flags: review?(joshmoz)
Attached patch v1 (obsolete) — Splinter Review
Uhm.
Attachment #402030 - Attachment is obsolete: true
Attachment #402031 - Flags: review?(joshmoz)
Attachment #402030 - Flags: review?(joshmoz)
Attached patch v1 (obsolete) — Splinter Review
(tabs)
Attachment #402031 - Attachment is obsolete: true
Attachment #402032 - Flags: review?(joshmoz)
Attachment #402031 - Flags: review?(joshmoz)
Attached patch v1Splinter Review
Attachment #402032 - Attachment is obsolete: true
Attachment #402033 - Flags: review?(joshmoz)
Attachment #402032 - Flags: review?(joshmoz)
Attachment #402033 - Flags: review?(joshmoz) → review+
Comment on attachment 402033 [details] [diff] [review]
v1

dbaron, can I get a quick rs on the layout/style/ changes?
Attachment #402033 - Flags: review?(dbaron)
Attachment #402033 - Flags: review?(dbaron) → review+
http://hg.mozilla.org/mozilla-central/rev/58922624da1c
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Depends on: 518085
You need to log in before you can comment on or make changes to this bug.