517412 - nsLookAndFeel.mm fails to compile 64-bit

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Josh Aas]

nsLookAndFeel.mm fails to compile 64-bit. Problematic API usage:

::GetThemeBrushAsColor
::GetThemeTextColor
::GetThemeAccentColors
::GetThemeScrollBarArrowStyle
::GetThemeScrollBarThumbStyle

Comment 1

[Markus Stange [:mstange]]

Attachment: comparison testcase

Comment 2

[Markus Stange [:mstange]]

Attachment: comparison testcase

Comment 3

[Markus Stange [:mstange]]

Attachment: v1

This is really no fun at all. Most of those color names don't make sense on OS X, so I've either tried to find a matching NSColor color or hardcoded it to the traditional value. Moreover, many of these colors are completely unused and could be removed, but I don't want to do that in this bug. (Actually I don't want to do it at all, since it's really tedious work...)

The only colors that the user can influence are "system appeararance" color and the selection color. I've explicitly made sure that we respond to those colors correctly.

The "accent" colors that I'm removing were used for pre-Aqua metal scrollbars. We don't need them any more.

Comment 4

[Markus Stange [:mstange]]

Attachment: v1

Uhm.

Comment 5

[Markus Stange [:mstange]]

Attachment: v1

(tabs)

Comment 6

[Markus Stange [:mstange]]

Attachment: v1

Comment 7

[Markus Stange [:mstange]]

Comment on attachment 402033 [details] [diff] [review]
v1

dbaron, can I get a quick rs on the layout/style/ changes?

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 402033 [details] [diff] [review]
v1

yep

Comment 9

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/58922624da1c