Closed Bug 517415 Opened 15 years ago Closed 15 years ago

nsNativeThemeCocoa.mm fails to compile 64-bit

Categories

(Core :: Widget: Cocoa, defect)

Product:
Core
Component:
Widget: Cocoa
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.3a1

People

(Reporter: jaas, Assigned: mstange)

References

(
URL
)

Details

Attachments

(1 file)

v1
4.15 KB, patch
jaas
: review+
Details | Diff | Splinter Review 
nsNativeThemeCocoa.mm fails to compile 64-bit. Problematic API usage:

::GetThemeScrollBarArrowStyle
::GetThemeScrollBarArrowStyle

Also, the signature for GreyGradientCallback is incorrect for 64-bit:

-static void GreyGradientCallback(void* aInfo, const float* aIn, float* aOut)
+static void GreyGradientCallback(void* aInfo, const CGFloat* aIn, CGFloat* aOut)
Attached patch v1 — — Splinter Review 

        Attachment #402036 -
        Flags: review?(joshmoz)

    
  

        Attachment #402036 -
        Flags: review?(joshmoz) → review+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/70896a54472d
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: