The default bug view has changed. See this FAQ.

Port Bug 363130: make menuitem icons 16x16px consistently on Windows/Linux.

RESOLVED FIXED in seamonkey2.1a3

Status

SeaMonkey
Themes
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: Philip Chee, Assigned: Philip Chee)

Tracking

({modern})

Trunk
seamonkey2.1a3
modern

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

8 years ago
While working on the Lightning integration I noticed that one of the menu items was significantly taller than the others in Modern but not in the Default theme. This was due to lightning using for the menu-item-iconic an image that was 24px x 24px.

I tracked this down to the modern menu.css doing this (in Bug 293207):

.menu-iconic-icon {
  min-width: 16px;
  min-height: 16px;
  list-style-image: inherit;
}

I propose porting toolkit Bug 363130 :(make menuitem icons 16x16px consistently on Windows/Linux, to match Mac.) and just use:

width: 16px;
height: 16px;
(Assignee)

Comment 1

8 years ago
Created attachment 401436 [details] [diff] [review]
Patch v1.0 Use width/height instead of min-width/min-height.

Minimal patch. Backports a fix from tookit themes.
Attachment #401436 - Flags: superreview?(neil)
Attachment #401436 - Flags: review?(neil)

Comment 2

8 years ago
Comment on attachment 401436 [details] [diff] [review]
Patch v1.0 Use width/height instead of min-width/min-height.

We have some non-16x16px icons. The ones I can think of offhand are in the Image Properties dialog in Composer.
Attachment #401436 - Flags: superreview?(neil)
Attachment #401436 - Flags: superreview-
Attachment #401436 - Flags: review?(neil)

Comment 3

8 years ago
(In reply to comment #0)
> While working on the Lightning integration I noticed that one of the menu items
> was significantly taller than the others in Modern but not in the Default
> theme. This was due to lightning using for the menu-item-iconic an image that
> was 24px x 24px.
Surely that's suboptimal, if the image is getting scaled all the time?
(Assignee)

Comment 4

8 years ago
> Surely that's suboptimal, if the image is getting scaled all the time?

This is even more inexplicable since there is the equivalent 16x16 graphic in mail-toolbar-small.png in the Thunderbird skin which lightning doesn't bother to use. Of course SeaMonkey doesn't have mail-toolbar{-small}.png, so all that happens is that a blank 24x24 area takes up vertical space in the menuitem.
(Assignee)

Comment 5

8 years ago
Also see Bug 516178 (Lightning uses hard coded Thunderbird skin paths to images).
(Assignee)

Comment 6

8 years ago
Created attachment 401724 [details] [diff] [review]
Patch v1.1 Additional fix for editorDialog.css

> We have some non-16x16px icons. The ones I can think of offhand are in the
> Image Properties dialog in Composer.

Added fix to editorDialog.css from classic.
Also removed some tabs.
Attachment #401436 - Attachment is obsolete: true
Attachment #401724 - Flags: superreview?(neil)
Attachment #401724 - Flags: review?(neil)
(Assignee)

Updated

8 years ago
No longer blocks: 465924

Comment 7

7 years ago
Places where we currently force 16x16 menu icons become redundant, of course.
(Assignee)

Comment 8

7 years ago
Created attachment 458593 [details] [diff] [review]
Patch v1.2 Remove redundant styles.

> Places where we currently force 16x16 menu icons become redundant, of course.
Fixed.

I looked at the tabs in editorDialog.css via CVS blame and they were there all the way back to 1.1 sspitzer :P .
Attachment #401724 - Attachment is obsolete: true
Attachment #458593 - Flags: review?(neil)
Attachment #401724 - Flags: superreview?(neil)
Attachment #401724 - Flags: review?(neil)

Updated

7 years ago
Attachment #458593 - Flags: review?(neil) → review+
(Assignee)

Updated

7 years ago
Attachment #458593 - Flags: superreview?(neil)

Updated

7 years ago
Attachment #458593 - Flags: superreview?(neil) → superreview+
(Assignee)

Comment 9

7 years ago
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/62a9693b8d4b
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Updated

7 years ago
Target Milestone: --- → seamonkey2.1a3
You need to log in before you can comment on or make changes to this bug.