Closed
Bug 517594
Opened 15 years ago
Closed 15 years ago
Add JS_ASSERT(sprop->id != JSVAL_NULL) almost everywhere
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: Waldo, Assigned: Waldo)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
11.69 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
Scope properties improperly used after being collected have a null id; adding assertions when sprops are used that their ids are non-null would let us see when we go awry as early as possible. This is basically every case where a scope property pointer is used in jsscope.cpp, except for a few cases that are entwined with scope sweeping where the id might validly be null.
Attachment #401551 -
Flags: review?(jorendorff)
|
||
Comment 1•15 years ago
|
||
Comment on attachment 401551 [details] [diff] [review] Sprinkle sprinkle OK. I guess it's traditional to say !JSVAL_IS_NULL(v) instead.
Attachment #401551 -
Flags: review?(jorendorff) → review+
|
Assignee | |
Comment 2•15 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/c3703b9b0033
Whiteboard: fixed-in-tracemonkey
|
||
Comment 3•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/c3703b9b0033
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•