517600 - opening an additional fennec window doesn't work

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

The initial window loading code depends on being passed in a command line object, and fails if that doesn't occur.

The pageloader used for perf tests does its tests in a new window. Not sure that's the best strategy for testing going forward (I think there may be single-window assumptions in our code), but it's fairly easy to fix just to get things running.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: better (slightly more complicated) patch

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: actual better patch

I fail at attaching the right patches.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #0)
> The initial window loading code depends on being passed in a command line
> object, and fails if that doesn't occur.

.. because we never end up adding a tab, so _updateWidth called from the resize handler throws, because this.firstChild is null.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mobile-browser/rev/cafbf066fef9

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

not sure how I can verify this?  Any thoughts?