Closed Bug 517600 Opened 11 years ago Closed 11 years ago

opening an additional fennec window doesn't work

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
fennec1.0b4

People

(Reporter: Gavin, Assigned: Gavin)

References

Details

Attachments

(1 file, 2 obsolete files)

The initial window loading code depends on being passed in a command line object, and fails if that doesn't occur.

The pageloader used for perf tests does its tests in a new window. Not sure that's the best strategy for testing going forward (I think there may be single-window assumptions in our code), but it's fairly easy to fix just to get things running.
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #401555 - Flags: review?(mark.finkle)
Attachment #401555 - Attachment is obsolete: true
Attachment #401556 - Flags: review?(mark.finkle)
Attachment #401555 - Flags: review?(mark.finkle)
I fail at attaching the right patches.
Attachment #401556 - Attachment is obsolete: true
Attachment #401558 - Flags: review?(mark.finkle)
Attachment #401556 - Flags: review?(mark.finkle)
(In reply to comment #0)
> The initial window loading code depends on being passed in a command line
> object, and fails if that doesn't occur.

.. because we never end up adding a tab, so _updateWidth called from the resize handler throws, because this.firstChild is null.
Attachment #401558 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mobile-browser/rev/cafbf066fef9
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → B4
not sure how I can verify this?  Any thoughts?
You need to log in before you can comment on or make changes to this bug.