Note: There are a few cases of duplicates in user autocompletion which are being worked on.

TestHarness.h should provide a directory provider for a profile directory

RESOLVED FIXED in mozilla1.9.3a1

Status

()

Core
XPCOM
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: sdwilsh, Assigned: sdwilsh)

Tracking

Trunk
mozilla1.9.3a1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

7.28 KB, patch
bsmedberg
: review+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
Created attachment 401561 [details] [diff] [review]
v1.0

This will make writing certain native code tests much easier.  Having each test have to make a profile directory is painful.  We already do this for free in our other test harnesses, so we should here too.
Attachment #401561 - Flags: review?(benjamin)
(Assignee)

Updated

8 years ago
Whiteboard: [needs review bsmedberg]
Comment on attachment 401561 [details] [diff] [review]
v1.0

>diff --git a/xpcom/tests/TestHarness.h b/xpcom/tests/TestHarness.h

>-static PRBool
>+PRBool
> StartProfiling(const char* profileName)

This was in some other bug. Please make these inline as you remove the static.
Attachment #401561 - Flags: review?(benjamin) → review+
(Assignee)

Updated

8 years ago
Whiteboard: [needs review bsmedberg] → [can land]
(Assignee)

Comment 2

8 years ago
Addressed that comment before I pushed.

http://hg.mozilla.org/mozilla-central/rev/467f14a11325
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Whiteboard: [can land]
(Assignee)

Comment 3

8 years ago
Backed out for possible breakage.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 4

8 years ago
Created attachment 403939 [details] [diff] [review]
v1.1

Need to also implement GetFiles for TestRegistrationOrder to pass.  Not sure how make check worked without this before...
Attachment #401561 - Attachment is obsolete: true
Attachment #403939 - Flags: review?(benjamin)
(Assignee)

Updated

8 years ago
Whiteboard: [needs review bsmedberg]
Attachment #403939 - Flags: review?(benjamin) → review+
(Assignee)

Comment 5

8 years ago
http://hg.mozilla.org/mozilla-central/rev/e11697ad33bd
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED
Whiteboard: [needs review bsmedberg]
(Assignee)

Comment 6

8 years ago
Not sure if this needs to be documented, but I'll leave that up to sheppy.
Keywords: dev-doc-needed
Whiteboard: [doc-waiting-1.9.3]
From what I gather, all this is doing is making it possible for tests to have a profile directory automatically created and destroyed? Or am I misunderstanding the patch here?
(Assignee)

Comment 8

7 years ago
(In reply to comment #7)
> From what I gather, all this is doing is making it possible for tests to have a
> profile directory automatically created and destroyed? Or am I misunderstanding
> the patch here?
that is it
After looking at this for a while, this doesn't look like it impacts any existing documentation. We do need more and better documentation for creating tests and whatnot, but that's beyond the scope of this particular bug, so I'm removing the doc needed flag here.
Keywords: dev-doc-needed
Whiteboard: [doc-waiting-1.9.3]
You need to log in before you can comment on or make changes to this bug.