517604 - TestHarness.h should provide a directory provider for a profile directory

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

This will make writing certain native code tests much easier.  Having each test have to make a profile directory is painful.  We already do this for free in our other test harnesses, so we should here too.

Comment 1

[Benjamin Smedberg]

Comment on attachment 401561 [details] [diff] [review]
v1.0

>diff --git a/xpcom/tests/TestHarness.h b/xpcom/tests/TestHarness.h

>-static PRBool
>+PRBool
> StartProfiling(const char* profileName)

This was in some other bug. Please make these inline as you remove the static.

Comment 2

[Shawn Wilsher :sdwilsh]

Addressed that comment before I pushed.

http://hg.mozilla.org/mozilla-central/rev/467f14a11325

Comment 3

[Shawn Wilsher :sdwilsh]

Backed out for possible breakage.

Comment 4

[Shawn Wilsher :sdwilsh]

Attachment: v1.1

Need to also implement GetFiles for TestRegistrationOrder to pass.  Not sure how make check worked without this before...

Comment 5

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/mozilla-central/rev/e11697ad33bd

Comment 6

[Shawn Wilsher :sdwilsh]

Not sure if this needs to be documented, but I'll leave that up to sheppy.

Comment 7

[Eric Shepherd [:sheppy]]

From what I gather, all this is doing is making it possible for tests to have a profile directory automatically created and destroyed? Or am I misunderstanding the patch here?

Comment 8

[Shawn Wilsher :sdwilsh]

(In reply to comment #7)
> From what I gather, all this is doing is making it possible for tests to have a
> profile directory automatically created and destroyed? Or am I misunderstanding
> the patch here?
that is it

Comment 9

[Eric Shepherd [:sheppy]]

After looking at this for a while, this doesn't look like it impacts any existing documentation. We do need more and better documentation for creating tests and whatnot, but that's beyond the scope of this particular bug, so I'm removing the doc needed flag here.