Closed
Bug 517604
Opened 15 years ago
Closed 15 years ago
TestHarness.h should provide a directory provider for a profile directory
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: sdwilsh, Assigned: sdwilsh)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
7.28 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
This will make writing certain native code tests much easier. Having each test have to make a profile directory is painful. We already do this for free in our other test harnesses, so we should here too.
Attachment #401561 -
Flags: review?(benjamin)
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [needs review bsmedberg]
|
||
Comment 1•15 years ago
|
||
Comment on attachment 401561 [details] [diff] [review]
v1.0
>diff --git a/xpcom/tests/TestHarness.h b/xpcom/tests/TestHarness.h
>-static PRBool
>+PRBool
> StartProfiling(const char* profileName)
This was in some other bug. Please make these inline as you remove the static.
Attachment #401561 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [needs review bsmedberg] → [can land]
|
|
Assignee | |
Comment 2•15 years ago
|
||
Addressed that comment before I pushed.
http://hg.mozilla.org/mozilla-central/rev/467f14a11325
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [can land]
|
|
Assignee | |
Comment 3•15 years ago
|
||
Backed out for possible breakage.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 4•15 years ago
|
||
Need to also implement GetFiles for TestRegistrationOrder to pass. Not sure how make check worked without this before...
Attachment #401561 -
Attachment is obsolete: true
Attachment #403939 -
Flags: review?(benjamin)
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [needs review bsmedberg]
|
|
||
Updated•15 years ago
|
Attachment #403939 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 5•15 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
Whiteboard: [needs review bsmedberg]
|
|
Assignee | |
Comment 6•15 years ago
|
||
Not sure if this needs to be documented, but I'll leave that up to sheppy.
Keywords: dev-doc-needed
|
||
Updated•15 years ago
|
Whiteboard: [doc-waiting-1.9.3]
|
|
||
Comment 7•14 years ago
|
||
From what I gather, all this is doing is making it possible for tests to have a profile directory automatically created and destroyed? Or am I misunderstanding the patch here?
|
|
Assignee | |
Comment 8•14 years ago
|
||
(In reply to comment #7)
> From what I gather, all this is doing is making it possible for tests to have a
> profile directory automatically created and destroyed? Or am I misunderstanding
> the patch here?
that is it
|
|
||
Comment 9•14 years ago
|
||
After looking at this for a while, this doesn't look like it impacts any existing documentation. We do need more and better documentation for creating tests and whatnot, but that's beyond the scope of this particular bug, so I'm removing the doc needed flag here.
Keywords: dev-doc-needed
Whiteboard: [doc-waiting-1.9.3]
You need to log in
before you can comment on or make changes to this bug.
Description
•