Closed Bug 517744 Opened 10 years ago Closed 10 years ago

layout/reftests/svg/sizing/dynamic--* reftests are too slow

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: mats, Assigned: mats)

References

Details

Attachments

(1 file)

Running the following 6 reftests:

layout/reftests/svg/sizing/
  dynamic--inline-css-height.xhtml
  dynamic--inline-css-width.xhtml
  dynamic--inline-resize-cb-height.xhtml
  dynamic--inline-resize-cb-width.xhtml
  dynamic--inline-resize-window-width.xhtml
  dynamic--object-svg-unloaded.xhtml

takes about 35 seconds.  The problem seems to be this:

  // in case we're not gecko
  setTimeout(notify_test_finished, 5000);

can we conditionalize that somehow?
We shouldn't be using the timeout at all, we should be getting a MozReftestInvalidate much sooner than that.

Perhaps I should just backout bug 509274
Blocks: 509274
Attached patch fix?Splinter Review
FWIW, this works reliably in my local Linux debug build and two runs on
TryServer were green, so it might be worth a try?
Lovely. r=longsonr even though you don't need it. Thanks for sorting this out.
http://hg.mozilla.org/mozilla-central/rev/6635995931c9
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Ouch, well it was worth a try at least.
Should we reopen bug 509274 or file a new bug?
Depends on: 518274
Filed bug 518274.
Assignee: nobody → matspal
Flags: in-testsuite+
Target Milestone: --- → mozilla1.9.3a1
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.