517744 - layout/reftests/svg/sizing/dynamic--* reftests are too slow

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Mats Palmgren (inactive)]

Running the following 6 reftests:

layout/reftests/svg/sizing/
  dynamic--inline-css-height.xhtml
  dynamic--inline-css-width.xhtml
  dynamic--inline-resize-cb-height.xhtml
  dynamic--inline-resize-cb-width.xhtml
  dynamic--inline-resize-window-width.xhtml
  dynamic--object-svg-unloaded.xhtml

takes about 35 seconds.  The problem seems to be this:

  // in case we're not gecko
  setTimeout(notify_test_finished, 5000);

can we conditionalize that somehow?

Comment 1

[Robert Longson [:longsonr]]

We shouldn't be using the timeout at all, we should be getting a MozReftestInvalidate much sooner than that.

Perhaps I should just backout bug 509274

Comment 2

[Mats Palmgren (inactive)]

Attachment: fix?

FWIW, this works reliably in my local Linux debug build and two runs on
TryServer were green, so it might be worth a try?

Comment 3

[Robert Longson [:longsonr]]

Lovely. r=longsonr even though you don't need it. Thanks for sorting this out.

Comment 4

[Mats Palmgren (inactive)]

http://hg.mozilla.org/mozilla-central/rev/6635995931c9

Comment 5

[Markus Stange [:mstange]]

Now that this has landed, we're seeing bug 509274 again:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1253658060.1253668462.26439.gz

Comment 6

[Mats Palmgren (inactive)]

Ouch, well it was worth a try at least.
Should we reopen bug 509274 or file a new bug?

Comment 7

[Mats Palmgren (inactive)]

Filed bug 518274.