Closed
Bug 517877
Opened 15 years ago
Closed 15 years ago
make Core Text back-end default on trunk
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: jaas, Assigned: jaas)
References
Details
Attachments
(1 file)
1.01 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
We should enable Core Text by default on trunk.
Attachment #401848 -
Flags: review?(ted.mielczarek)
Comment 2•15 years ago
|
||
Comment on attachment 401848 [details] [diff] [review]
fix v1.0
Do we need to preserve --disable-coretext still? I guess you said we don't want to rip out all our 10.4 support yet. Can you file a followup on removing that + all the MOZ_CORETEXT ifdefs once we're sure about dropping 10.4?
Attachment #401848 -
Flags: review?(ted.mielczarek) → review+
pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/086b132ab779
We'll be sure to remove all of the configure stuff when we remove ATSUI.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 4•15 years ago
|
||
It appears that this bug's checkin fixed a crasher on trunk (Bug 534672), which still crashes 1.9.1 and 1.9.2.
Is there any chance we could backport this change (and the code it enables) to either or both of those branches?
Comment 5•15 years ago
|
||
Hm, I just tried building 1.9.2 with this bug's patch applied, and I got:
{
checking for Core Text... no
configure: error: --enable-coretext requires MacOS SDK 10.5 or newer
*** Fix above errors and then restart with "make -f client.mk build"
make[2]: *** [configure] Error 1
make[1]: *** [/builds/slave/sendchange-macosx-hg/build/objdir/ppc/Makefile] Error 2
make: *** [build] Error 2
}
which leads me to believe this can't be backported. :(
Comment 6•15 years ago
|
||
(In reply to comment #4)
> It appears that this bug's checkin fixed a crasher on trunk (Bug 534672), which
> still crashes 1.9.1 and 1.9.2.
>
> Is there any chance we could backport this change (and the code it enables) to
> either or both of those branches?
Not easily, because we're still building those against the 10.4 SDK, which does not support the Core Text APIs.
Updated•15 years ago
|
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.3a1
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•