517996 - Tools|Delete Mail Marked As Junk Folder not working in 20090921 nightly

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Backend, defect)

Description

[NoOp]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre) Gecko/20090918 Lightning/1.0pre SeaMonkey/2.0pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre) Gecko/20090921 Lightning/1.0pre SeaMonkey/2.0pre

Tools|Delete Mail Marked As Junk Folder not working in 20090921 nightly

Build identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre)
Gecko/20090921 Lightning/1.0pre SeaMonkey/2.0pre

Also does not work in:
Does not work with:
<http://ftp.mozilla.org/pub/mozilla.org/seamonkey/nightly/2009-09-20-00-comm-1.9.1/>
[seamonkey-2.0pre.en-US.linux-i686.tar.bz2 20-Sep-2009 01:04 12M]

Works with:
<http://ftp.mozilla.org/pub/mozilla.org/seamonkey/nightly/2009-09-18-23-comm-1.9.1/>

Build identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre)
Gecko/20090918 Lightning/1.0pre SeaMonkey/2.0pre



Reproducible: Always

Steps to Reproduce:
1. Filter spam/junk to email account 'Junk' folder.
2. Use 'Tools|Delete Mail Marked as junk Folder' 

Actual Results:  
emails marked as junk are not deleted/moved to trash.

Comment 1

[Robert Kaiser]

Kent, any clue what could be up there?

Comment 2

[NoOp]

Still not working in today's nightly:

Build identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre) Gecko/20090922 Lightning/1.0pre SeaMonkey/2.0pre

Comment 3

[Kent James (:rkent)]

Error console shows "reference to undefined property gFolderDisplay.displayedFolder" in junkCommands.js, so this is one of those TB/SM difference issues. Should be easy to fix though, so I'll work on it.

Comment 4

[Kent James (:rkent)]

I'm pretty sure that this is a regression from bug 516453.

Comment 5

[Kent James (:rkent)]

Bug 517238 adds some additional stubs for gFolderDisplay, but not the one I need. But I will wait until that lands to work on this because of bitrotting issues. (Maybe dependency isn't technically correct, but it does give me the bugmail notification that I want.)

Comment 6

[Philip Chee]

get displayedFolder()
{
  return gDBView ? gDBView.msgFolder : null;
}

Comment 7

[[e-mail]]

(In reply to comment #6)
> get displayedFolder()
> {
>   return gDBView ? gDBView.msgFolder : null;
> }
Which folder do we want in the case of a) a single-folder search folder? b) a server (account)? gMsgFolderSelected returns the server or logical folder as displayed; gDBView && gDBView.msgFolder returns the real folder underlying the search, but never returns a server.

Comment 8

[Kent James (:rkent)]

(In reply to comment #7)
> Which folder do we want in the case of a) a single-folder search folder? b) a
> server (account)? gMsgFolderSelected returns the server or logical folder as
> displayed; gDBView && gDBView.msgFolder returns the real folder underlying the
> search, but never returns a server.

At least for the junkCommands.js case, we want the underlying folder for the single-folder case, and the virtual folder for the cross-folder case. The server is don't care, as the underlying command is disabled if there are no messages selected, and you can't select a message when you are pointing to a server.

Comment 9

[Kent James (:rkent)]

Attachment: use gMsgFolderSelected as in the previous code

Comment 10

[[e-mail]]

Comment on attachment 402304 [details] [diff] [review]
use gMsgFolderSelected as in the previous code

Aren't you going to remove the detection code from junkCommands.js ?

Comment 11

[Kent James (:rkent)]

(In reply to comment #10)
> (From update of attachment 402304 [details] [diff] [review])
> Aren't you going to remove the detection code from junkCommands.js ?

Yes I suppose I should.

Comment 12

[Kent James (:rkent)]

Attachment: Removing unneeded check in junkCommands.js

Comment 13

[[e-mail]]

Comment on attachment 402459 [details] [diff] [review]
Removing unneeded check in junkCommands.js

Well, I don't mind if you really want to do it piecemeal, but maybe we should clean up junkCommands.js in a separate bug.

Comment 14

[Kent James (:rkent)]

Comment on attachment 402459 [details] [diff] [review]
Removing unneeded check in junkCommands.js

a=dmose on IRC for mailnews checkin

Comment 15

[Kent James (:rkent)]

Comment on attachment 402459 [details] [diff] [review]
Removing unneeded check in junkCommands.js

I need the SM approval as well before I can checkin.

Comment 16

[Kent James (:rkent)]

Checked in: http://hg.mozilla.org/comm-central/rev/b3ca8b51f9fe

Comment 17

[NoOp]

Thanks guys.

Comment 18

[NoOp]

Confirmed as fixed.

Build identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre) Gecko/20090925 Lightning/1.0pre SeaMonkey/2.0pre