NJ merge: remove VerboseBlockReader, other related stuff

VERIFIED FIXED

Status

Tamarin
Baseline JIT (CodegenLIR)
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: njn, Assigned: Rick Reitmaier)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
Created attachment 401979 [details] [diff] [review]
patch

This patch:

- Removes VerboseBlockReader, which is dead (it was removed from TM in bug 511329).
- Reformats a small piece of debug-output code to match TM.
- Removes another small piece of debug-output code that isn't in TM (the
 "FIXME" one -- I'm not sure about that one).
- Fixed a typo that's been fixed in TM.

The patch hasn't been tested, nor even compiled, but hopefully is a useful start.
(Reporter)

Comment 1

8 years ago
With Graydon's help I managed to build TR (well, TW, since I'm using Rick's tamarin-work repo), so the patch compiles cleanly, but I haven't tested it.
(Assignee)

Updated

8 years ago
Attachment #401979 - Flags: superreview?(edwsmith)
Attachment #401979 - Flags: review+
(Assignee)

Comment 2

8 years ago
Comment on attachment 401979 [details] [diff] [review]
patch

I've +'ed but asking ed for another set of eyes on it.

Updated

8 years ago
Attachment #401979 - Flags: superreview?(edwsmith) → superreview+
(Assignee)

Comment 3

8 years ago
pushed http://hg.mozilla.org/tamarin-redux/rev/233c08404581
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Comment 4

8 years ago
Resolved fixed engineering / work item that has been pushed.  Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.