Closed
Bug 518020
Opened 15 years ago
Closed 15 years ago
NJ merge: remove VerboseBlockReader, other related stuff
Categories
(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: n.nethercote, Assigned: rreitmai)
References
Details
Attachments
(1 file)
|
4.40 KB,
patch
|
rreitmai
:
review+
edwsmith
:
superreview+
|
Details | Diff | Splinter Review |
This patch: - Removes VerboseBlockReader, which is dead (it was removed from TM in bug 511329). - Reformats a small piece of debug-output code to match TM. - Removes another small piece of debug-output code that isn't in TM (the "FIXME" one -- I'm not sure about that one). - Fixed a typo that's been fixed in TM. The patch hasn't been tested, nor even compiled, but hopefully is a useful start.
|
Reporter | |
Comment 1•15 years ago
|
||
With Graydon's help I managed to build TR (well, TW, since I'm using Rick's tamarin-work repo), so the patch compiles cleanly, but I haven't tested it.
|
Assignee | |
Updated•15 years ago
|
Attachment #401979 -
Flags: superreview?(edwsmith)
Attachment #401979 -
Flags: review+
|
|
Assignee | |
Comment 2•15 years ago
|
||
Comment on attachment 401979 [details] [diff] [review] patch I've +'ed but asking ed for another set of eyes on it.
|
||
Updated•15 years ago
|
Attachment #401979 -
Flags: superreview?(edwsmith) → superreview+
|
|
Assignee | |
Comment 3•15 years ago
|
||
pushed http://hg.mozilla.org/tamarin-redux/rev/233c08404581
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Comment 4•15 years ago
|
||
Resolved fixed engineering / work item that has been pushed. Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•