518058 - nightly update generator barfing on missing file

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

In particular http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2009/09/2009-09-21-05-mozilla-central-l10n/firefox-3.7a1pre.el.win32.complete.mar

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

The error uploading el was:

d:/mozilla-build/python25/python2.5.exe ../../build/upload.py --base-path ../../dist "../../dist/firefox-3.7a1pre.el.win32.zip" ../../dist/install/firefox-3.7a1pre.el.langpack.xpi
Traceback (most recent call last):
  File "/usr/bin/post_upload.py", line 243, in ?
    func(options, upload_dir, files)
  File "/usr/bin/post_upload.py", line 74, in ReleaseToDated
    CopyFileToDir(f, upload_dir, longDatedPath)
  File "/usr/bin/post_upload.py", line 34, in CopyFileToDir
    os.makedirs(full_dest_dir, 0755)
  File "/usr/lib/python2.3/os.py", line 154, in makedirs
    mkdir(name, mode)
OSError: [Errno 17] File exists: '/home/ftp/pub/firefox/nightly/2009/09/2009-09-21-05-mozilla-central-l10n'
Uploading e:\builds\moz2_slave\mozilla-central-win32-l10n-nightly\build\mozilla-central\dist\firefox-3.7a1pre.el.win32.zip
Uploading e:\builds\moz2_slave\mozilla-central-win32-l10n-nightly\build\mozilla-central\dist\install\firefox-3.7a1pre.el.langpack.xpi
Running post-upload command: post_upload.py -p firefox  -b mozilla-central-l10n  --buildid 20090921050209 --release-to-latest --release-to-dated
Encountered error while uploading
Command ['ssh', '-o', 'IdentityFile=~/.ssh/ffxbld_dsa', '[e-mail]', 'post_upload.py -p firefox  -b mozilla-central-l10n  --buildid 20090921050209 --release-to-latest --release-to-dated "/tmp/tmp.EQLELP3658/" "/tmp/tmp.EQLELP3658//firefox-3.7a1pre.el.win32.zip" "/tmp/tmp.EQLELP3658/install/firefox-3.7a1pre.el.langpack.xpi"'] returned non-zero exit code: 1
make: *** [l10n-upload-el] Error 2

Is that the same as bug 517428 ? Hard to imagine win32 collided with any other platform trying to upload.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

I just took the expedient approach and removed
  build/0/Firefox/mozilla-central/WINNT_x86-msvc/20090921050209/el
from aus2-staging:/opt/aus2 and prometheus-vm:/builds/nightly-update-generation, with the cron job disabled. It's back in action now.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Halt the build if the upload fails

In the nightly case we want to not publish the update snippet if the upload fails, and that's all that follows this doUpload step. I'm not sure what other consumers of this want.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 402035 [details] [diff] [review]
Halt the build if the upload fails

http://hg.mozilla.org/build/buildbotcustom/rev/d5b51587d986

pm and pm02 reconfig'd.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Nightly updates are working fine today and the patch means we shouldn't get into this situation with l10n again.