518101 - Rename "waitFor" class to "waitForEvents"

Status: VERIFIED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1

Mikeal has added the waitFor class because he used it in bug 489474 to wait for events to occur. The name itself doesn't tell anything about this function and should be renamed to better reflect the feature behind it.

This patch renames the class and makes it accessible via waitForEvents.

Comment 2

[cmtalbert]

I don't see you changing any of the consumers of this API, so this patch looks incomplete.  It looks like you are landing the tests in bug 489474 today...are you changing this API in those tests before landing?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

No, the video test will not land today. I have some problems with current regressions and have to do some updates. So I will update those later. AFAIK those are the only tests which make use of the waitFor call. Do you know others?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Clint, ping?

Comment 5

[cmtalbert]

Be sure to change the tests when they land. :)

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed as http://github.com/mikeal/mozmill/commit/a0f6b75af414071969c45f46b86fcc5221a56504

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

With the landing of this patch we have a regression which makes this object unavailable.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Follow-up

Changes in this patch which we definitely need for the next release:

* Changed usage to waitForEvents.init() and waitForEvents.wait()
* We should use an instance of waitForEvents as a member of MozMillController as we do for all the other functions. That's more consistent
* Throw a real error instead of a string when timeout happens

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 404460 [details] [diff] [review]
Follow-up

Send a pull request to Mikeal with http://github.com/whimboo/mozmill/commit/2c9cbfeecd76659156a7836b50b7e68b8e7570fb

Comment 10

[Mikeal Rogers [:mikeal] (mrogers@)]

merged to mikeal/master

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed based on changeset:
http://github.com/mikeal/mozmill/commit/2c9cbfeecd76659156a7836b50b7e68b8e7570fb