Created attachment 402072 [details] [diff] [review] Patch v1 Mikeal has added the waitFor class because he used it in bug 489474 to wait for events to occur. The name itself doesn't tell anything about this function and should be renamed to better reflect the feature behind it. This patch renames the class and makes it accessible via waitForEvents.
I don't see you changing any of the consumers of this API, so this patch looks incomplete. It looks like you are landing the tests in bug 489474 today...are you changing this API in those tests before landing?
No, the video test will not land today. I have some problems with current regressions and have to do some updates. So I will update those later. AFAIK those are the only tests which make use of the waitFor call. Do you know others?
Be sure to change the tests when they land. :)
With the landing of this patch we have a regression which makes this object unavailable.
Created attachment 404460 [details] [diff] [review] Follow-up Changes in this patch which we definitely need for the next release: * Changed usage to waitForEvents.init() and waitForEvents.wait() * We should use an instance of waitForEvents as a member of MozMillController as we do for all the other functions. That's more consistent * Throw a real error instead of a string when timeout happens
Comment on attachment 404460 [details] [diff] [review] Follow-up Send a pull request to Mikeal with http://github.com/whimboo/mozmill/commit/2c9cbfeecd76659156a7836b50b7e68b8e7570fb
merged to mikeal/master
Verified fixed based on changeset: http://github.com/mikeal/mozmill/commit/2c9cbfeecd76659156a7836b50b7e68b8e7570fb