518111 - Avoid using <stringbundle> and switch to nsIStringBundleService

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Fennec uses quite a few string bundles and mainly uses <stringbundle> to access the strings. The XBL overhead can be avoided. We should switch to use nsIStringBundleService, perhaps adding a global getter like we do with gPrefService.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Services.strings exists. We should do this to reduce XBL overhead and maybe get some Ts improvements

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

* Removes <stringbundle> in browser.xul and adds a lazy 'Strings' object for accessing string bundles.
* Changes getString -> GetStringFromName
* Changes getFormmattedString -> FormatStringFromName

I am running some Ts tests for before and after results and will post here when finished.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Average Ts results over 30 runs:

Before: 6735 ms
After:  6687 ms

So we might have a small improvement. The main goal is removing as much XUL and XBL overhead as we can. This is a start.

Comment 4

[Matt Brubeck (:mbrubeck)]

Comment on attachment 500607 [details] [diff] [review]
patch

You should also remove the Elements.browserBundle getter.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed with Elements.browserBundle change
http://hg.mozilla.org/mobile-browser/rev/56c2e0ec76f4