518144 - Socorro UI: empty signatures in the UI still need a link to the underlying data

Status: RESOLVED FIXED

(Socorro :: General, task, P2)

Description

[K Lars Lohn [:lars] [:klohn]]

Sometimes a crash signature cannot be generated from a crash.  The processor, when encountering this, provides an explanation in the 'processor_notes' field.  Sometimes, crashes without signature appear in searches and reports.  In the UI, the signature is often the base text for the link that allows the user to drill down to get more information.  If the signature is blank, the link is omitted, even though there is associated data.  The user has no way to get to the crashes with no signature.

Action: in locations where there are normally signatures as links, put "no signature found" as the text of the link in the case where the signature is blank.

This change affects the results of a search, as well as the top_crashes_by_signature reports.

Comment 2

[Frank Griswold [:griswolf] [:fgriswold]]

Attachment: Expect this will provide 'signature uknown' instead of empty, for linking

This proposed patch was done by code examination, has not been tested

Comment 3

[Frank Griswold [:griswolf] [:fgriswold]]

Comment on attachment 403896 [details] [diff] [review]
Expect this will provide 'signature uknown' instead of empty, for linking

On testing, the patch doesn't work.

Comment 4

[Frank Griswold [:griswolf] [:fgriswold]]

Attachment: Write "(signature unavailable)" as the link text, when otherwise it would be empty string

Comment 5

[Austin King [:ozten]]

Comment on attachment 404695 [details] [diff] [review]
Write "(signature unavailable)" as the link text, when otherwise it would be empty string

I liked you first patch better. 

Use php's empty function to determine if a string is NULL or contains no characters.

Comment 6

[Frank Griswold [:griswolf] [:fgriswold]]

Committed revision 1372. Now works for me.

Comment 7

[Damon Sicore (:damons)]

Need to address this as the number of empty signature crashes is twice the number of our top crashes.

Comment 8

[Frank Griswold [:griswolf] [:fgriswold]]

See comment #6: The code is in place and waiting to be pulled onto production server

Comment 9

[Frank Griswold [:griswolf] [:fgriswold]]

Attachment: Fixes bug where the link URI is incorrect for a blank signature

Previous patch 'fixed' the display problem by displaying (signature unavailable) gave the href a display, but also inserted that string into the href's target URI. In hindsight, that's obvious...

Comment 11

[Austin King [:ozten]]

Comment on attachment 412293 [details] [diff] [review]
Fixes bug where the link URI is incorrect for a blank signature

Looks good.

Comment 12

[Frank Griswold [:griswolf] [:fgriswold]]

Committed revision 1469: 
URL: https://socorro.googlecode.com/svn/trunk/webapp-php/application/views/common/list_by_signature.php
URL: https://socorro.googlecode.com/svn/trunk/webapp-php/application/views/common/list_topcrashers.php

(Unable to fully test list_by_signature.php: Empty signatures are not now provided by the query/query form)

Comment 13

[Austin King [:ozten]]

The change in 1469 breaks link generation for the report/list links.

prior to 1469 the $url_params variable had a 'signature' key which is the exact signature which the user wants to click through too.

Picking up, will patch.

Comment 14

[Austin King [:ozten]]

(In reply to comment #13)
Fixing query/query display, which had removed $url_params['signature'] in previous commit. r1551 

The basic underlying goal of this bug is still not resolved. Bumping to 1.3. Sorry I missed this in the code review at comment #11

We should support a signature that is NULL or an empty string through-out the webapp. The work that was done changes the link's value, but doesn't address the common database queries should search for signature IS NULL OR signature = '' so that users can drill down on (signature unavailable) links.

Comment 15

[Austin King [:ozten]]

Created http://code.google.com/p/socorro/wiki/NullOrEmptySignatures to be linked to from the UI as "learn more"

Comment 16

[Austin King [:ozten]]

Attachment: General support for empty or null signatures

This patch adds general support for null or empty signatures.
It refactors the various constants off of the top crashers controller into the Crash library.

Test notes: Search for Firefox last week and a top result should be null closely followed by empty signatures.

Comment 17

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Comment on attachment 417998 [details] [diff] [review]
General support for empty or null signatures

Code looks fine.  Tested fine.  R+.

There is a lot of text on this page already, so we may want to replace the "Learn More" link with a "[?]" link.  Can add "Learn More" to the anchor title.

Comment 18

[Austin King [:ozten]]

Thanks for the review.
If we have a [?] image, I'm for it, but as just text it gets lost in the page.

Comment 19

[Austin King [:ozten]]

Sending        webapp-php/application/controllers/query.php
Sending        webapp-php/application/controllers/report.php
Sending        webapp-php/application/controllers/topcrasher.php
Sending        webapp-php/application/libraries/crash.php
Sending        webapp-php/application/models/common.php
Sending        webapp-php/application/views/common/list_by_signature.php
Sending        webapp-php/application/views/report/do_list.php
Transmitting file data .......
Committed revision 1613.