Closed Bug 518176 Opened 13 years ago Closed 11 years ago

TM: Support TraceVis in browser builds for devs

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: dmandelin, Unassigned)

References

Details

Attachments

(2 files)

In the JS configure script, --enable-tracevis enables TraceVis, simply by defining MOZ_TRACEVIS. To support this in the browser, we need to add such a flag to the top-level script that:

- passes --enable-tracevis to the JS configure script
- defines MOZ_TRACEVIS for the browser
- turns TraceVis for browser contexts created in nsJSEnvironment.cpp using JS_StartTraceVis.
Summary: TM: Support --enable-tracevis in browser builds for devs → TM: Support TraceVis in browser builds for devs
Blocks: 518177
Attached patch PatchSplinter Review
It turns out most of the immediate requirements were already done. All I had to do was add calls to turn it on and off.
Attached patch wipSplinter Review
Could we replace the above patch by something like that?

This way if we be easier to get some "per function" tracevis analysis without removing the capability to enable tracevis at startup and to stop it on browser shutdown.

For Fennec, we're planning to JIT the chrome UI as much as possible and such a capability to do it per function would be helpful.
(In reply to comment #2)
> Created an attachment (id=425914) [details]
> wip
> 
> Could we replace the above patch by something like that?
> 
> This way if we be easier to get some "per function" tracevis analysis without
> removing the capability to enable tracevis at startup and to stop it on browser
> shutdown.
> 
> For Fennec, we're planning to JIT the chrome UI as much as possible and such a
> capability to do it per function would be helpful.

Sounds good to me. If you've got a practical need for browser TraceVis and a solution that meets that need, I'm all for it.
> Sounds good to me. If you've got a practical need for browser TraceVis and a
> solution that meets that need, I'm all for it.

Nice.
There is also some minor changes to do into binlog.py and vis.py which I'm working on.
WONTFIX per bug 593527 comment 5.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.