518195 - [SUMO]: Forum URL's in email notifications are still in the old format

Status: VERIFIED FIXED

(support.mozilla.org :: Forum, task, P1)

Description

[Vishal Kamdar [:vish_moz]]

Summary: Forum URL's in email notifications are still in the old format

Steps to Reproduce:
1. log into SUMO stage (account 'A')
2. click on 'Support Forum'
3. click on one of the forums from 'Most popular topics'
4. click on 'watch this topic'
5. log in with your other account (account 'B') and post a comment on the same forum
6. you will receive an email about the new post on your account A's email add.

Expected result:
the link to the new post should be in the new format as described in  Bug 416479
( eg. link format http://support.mozilla.com/forums/1/1480)

Actual result:
the link to the post is in the olden format, https://support-stage.mozilla.org/tiki-view_forum_thread.php?forumId=1&comments_parentId=443829#threadId446780

Comment 1

[Vishal Kamdar [:vish_moz]]

Another place to fix the URL,
when you click on watch topic, the URL changes to old format, like http://support-stage.mozilla.org/tiki-view_forum_thread.php?locale=en-US&forumId=3&comments_parentId=446667&watch_event=forum_post_thread&watch_object=446667&watch_action=add

Comment 2

[Vishal Kamdar [:vish_moz]]

New Bug 518209 filed for comment #1

Comment 3

[Paul Craciunoiu [:paulc]]

A quick input: there was a pref for pretty urls as part of the patch in bug 416479. Hope that's what causes this :)

Comment 4

[Paul Craciunoiu [:paulc]]

Attachment: v1

$machine was assigned the dir path which included en-US/forum/$id/
This patch adopts the easy fix and makes $machine actually be just the base url. It also fixes the mail template.

Comment 6

[Paul Craciunoiu [:paulc]]

r52758 / r52759

Comment 7

[Vishal Kamdar [:vish_moz]]

Verified, FIXED.
now, the link in the email goes to the thread, https://support-stage.mozilla.org/en-US/forum/1/446784#threadId446915

Comment 8

[Vishal Kamdar [:vish_moz]]

Litmus TC, https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=9553