518242 - NJ: Remove insSkip and supporting machinery.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Graydon Hoare :graydon]

Split off of bug 402216. Skip instructions -- as of the landing of that bug -- have no function other than linking to previous chunks in the LIR buffer. The LirWriter::insSkip() function, the LIns::payload() function, and some quantity of comment and supporting noise are likely dead code now.

njn: feel free to take this one if you want once we're merged. I just put it here and assigned to self as a post-merge work placeholder.

Comment 1

[Nicholas Nethercote [inactive]]

(In reply to comment #0)
> Split off of bug 402216.

I think that should be bug 495734.

> njn: feel free to take this one if you want once we're merged. I just put it
> here and assigned to self as a post-merge work placeholder.

Happy to.

Comment 2

[Graydon Hoare :graydon]

(In reply to comment #1)
> (In reply to comment #0)
> > Split off of bug 402216.
> 
> I think that should be bug 495734.

Quite so. Where on earth did I pull that bug number out of?

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: patch

What a lovely patch.  LIR really has improved (ie. gotten simpler) over the past 10 months.

Comment 5

[Graydon Hoare :graydon]

Comment on attachment 411616 [details] [diff] [review]
patch

hooray!

Comment 6

[Nicholas Nethercote [inactive]]

http://hg.mozilla.org/projects/nanojit-central/rev/d0134ea858d0

Comment 7

[Nicholas Nethercote [inactive]]

http://hg.mozilla.org/tracemonkey/rev/02ece61b6ab7

Comment 8

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/02ece61b6ab7