Closed
Bug 518242
Opened 16 years ago
Closed 16 years ago
NJ: Remove insSkip and supporting machinery.
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: graydon, Assigned: n.nethercote)
References
Details
(Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey)
Attachments
(1 file)
|
13.02 KB,
patch
|
graydon
:
review+
|
Details | Diff | Splinter Review |
Split off of bug 402216. Skip instructions -- as of the landing of that bug -- have no function other than linking to previous chunks in the LIR buffer. The LirWriter::insSkip() function, the LIns::payload() function, and some quantity of comment and supporting noise are likely dead code now.
njn: feel free to take this one if you want once we're merged. I just put it here and assigned to self as a post-merge work placeholder.
|
Assignee | |
Comment 1•16 years ago
|
||
(In reply to comment #0)
> Split off of bug 402216.
I think that should be bug 495734.
> njn: feel free to take this one if you want once we're merged. I just put it
> here and assigned to self as a post-merge work placeholder.
Happy to.
Assignee: graydon → nnethercote
Depends on: 503556
|
Reporter | |
Comment 2•16 years ago
|
||
(In reply to comment #1)
> (In reply to comment #0)
> > Split off of bug 402216.
>
> I think that should be bug 495734.
Quite so. Where on earth did I pull that bug number out of?
|
|
Assignee | |
Comment 4•16 years ago
|
||
What a lovely patch. LIR really has improved (ie. gotten simpler) over the past 10 months.
Attachment #411616 -
Flags: review?(graydon)
|
|
Reporter | |
Comment 5•16 years ago
|
||
Comment on attachment 411616 [details] [diff] [review]
patch
hooray!
Attachment #411616 -
Flags: review?(graydon) → review+
|
|
Assignee | |
Comment 6•16 years ago
|
||
Whiteboard: fixed-in-nanojit
|
|
Assignee | |
Comment 7•16 years ago
|
||
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tracemonkey
|
||
Comment 8•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•