518418 - storage-mozStorage should use executeStep() instead of step()

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect)

Description

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Shawn says step() is deprecated and we should be using executeStep(). step() is deprecated due to duplicate APIs

Comment 1

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1

s/.step/.executeStep

Comment 2

[Shawn Wilsher :sdwilsh]

Comment on attachment 402422 [details] [diff] [review]
Patch v0.1

r=sdwilsh

Comment 3

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.2 (for check-in)

Missed one in the tests. Trivial change & tests pass, so carrying over r+

Comment 4

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Pushed http://hg.mozilla.org/mozilla-central/rev/e3e00288caa2

Comment 5

[Justin Dolske [:Dolske]]

Comment on attachment 402435 [details] [diff] [review]
Patch v0.2 (for check-in)

I'd like to take this on 1.9.2, mainly to help reduce future patch merge headaches. Should be ultra low-risk, and has plenty of existing test coverage.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Verified fixed on trunk by check-in.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 402435 [details] [diff] [review]
Patch v0.2 (for check-in)

approval1.9.2 requests aren't currently being monitored, since we're nearing RC freeze and there are too many outstanding requests, so I'm clearing this request. Feel free to re-request approval if you are confident that it's worth drivers' time to consider whether this non-blocker needs to land for 1.9.2 at this stage.