storage-mozStorage should use executeStep() instead of step()

VERIFIED FIXED in mozilla1.9.3a1

Status

()

VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: zpao, Assigned: zpao)

Tracking

Trunk
mozilla1.9.3a1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Shawn says step() is deprecated and we should be using executeStep(). step() is deprecated due to duplicate APIs
Created attachment 402422 [details] [diff] [review]
Patch v0.1

s/.step/.executeStep
Assignee: nobody → paul
Status: NEW → ASSIGNED
Attachment #402422 - Flags: review?(dolske)
Comment on attachment 402422 [details] [diff] [review]
Patch v0.1

r=sdwilsh
Attachment #402422 - Flags: review+
Attachment #402422 - Flags: review?(dolske) → review+
Created attachment 402435 [details] [diff] [review]
Patch v0.2 (for check-in)

Missed one in the tests. Trivial change & tests pass, so carrying over r+
Attachment #402422 - Attachment is obsolete: true
Attachment #402435 - Flags: review+
Pushed http://hg.mozilla.org/mozilla-central/rev/e3e00288caa2
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Comment on attachment 402435 [details] [diff] [review]
Patch v0.2 (for check-in)

I'd like to take this on 1.9.2, mainly to help reduce future patch merge headaches. Should be ultra low-risk, and has plenty of existing test coverage.
Attachment #402435 - Flags: approval1.9.2?
Verified fixed on trunk by check-in.
Status: RESOLVED → VERIFIED
Comment on attachment 402435 [details] [diff] [review]
Patch v0.2 (for check-in)

approval1.9.2 requests aren't currently being monitored, since we're nearing RC freeze and there are too many outstanding requests, so I'm clearing this request. Feel free to re-request approval if you are confident that it's worth drivers' time to consider whether this non-blocker needs to land for 1.9.2 at this stage.
You need to log in before you can comment on or make changes to this bug.