Closed Bug 518470 Opened 15 years ago Closed 15 years ago

Reduce button, toggle and row heights

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Maemo
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

(Whiteboard: [polish])

Attachments

(1 file)

Attached patch patchSplinter Review
In an effort to maximize the content on the screen, we are attempting to reduce the height of some elements while still making sure they are touch-friendly.

This patch:
* Changes row height to ~6mm everywhere (awesomebar, bookmark list, prefs, etc.)
* Changes button and toggle height to ~4mm 
* Changes toolbarbutton height to ~5mm (we have very few of these)
* Reduces the padding in the search bar and the url bar by half
** search bar is now ~6mm
** urlbar is now ~7mm
Attachment #402477 - Flags: review?(gavin.sharp)
Attachment #402477 - Flags: review?(gavin.sharp) → review+
pushed:
https://hg.mozilla.org/mobile-browser/rev/867a2dac0998
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [polish]
I have concerns about reducing general row height to 6mm given that the guidelines for general-population touchability are for 7mm.  Buttons can certainly be much less tall, though other platforms increase the size of their invisible touch area (i.e. "iceberg" buttons on the iphone).
I think this is a candidate for a unit test to be created in order to verify this bug.
Flags: in-testsuite?
Having tested this on-device I think it's worth using for b4 and getting more feedback about the 6mm row height.  The top and bottom bar fixes are good -- the shorter height works fine at the screen edges.
verified FIXED on build:

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20090928
Fennec/1.0b4pre
Status: RESOLVED → VERIFIED
Component: Linux/Maemo → General
OS: Linux → Linux (embedded)
QA Contact: maemo-linux → general
Hardware: x86 → ARM
bugspam
Assignee: nobody → mark.finkle
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: