518611 - Form Manager should use executeStep() instead of step()

Status: RESOLVED FIXED

(Toolkit :: Form Manager, defect)

Description

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Bug 452897 made it so that statements are automatically wrapped.
step() was deprecated in favor of executeStep().

Comment 1

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1

Comment 2

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Pushed http://hg.mozilla.org/mozilla-central/rev/cead80fe52d8

Comment 3

[Justin Dolske [:Dolske]]

Comment on attachment 402634 [details] [diff] [review]
Patch v0.1

I'd like to take this on 1.9.2, mainly to help reduce future patch merge headaches. Should be ultra low-risk, and has plenty of existing test coverage.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 402634 [details] [diff] [review]
Patch v0.1

approval1.9.2 requests aren't currently being monitored, since we're nearing RC freeze and there are too many outstanding requests, so I'm clearing this request. Feel free to re-request approval if you are confident that it's worth drivers' time to consider whether this non-blocker needs to land for 1.9.2 at this stage.