bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Form Manager should use executeStep() instead of step()

RESOLVED FIXED in mozilla1.9.3a1

Status

()

Toolkit
Form Manager
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: zpao, Assigned: zpao)

Tracking

Trunk
mozilla1.9.3a1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Bug 452897 made it so that statements are automatically wrapped.
step() was deprecated in favor of executeStep().
OS: Mac OS X → All
Hardware: x86 → All
Summary: Satchel Storage usage changes: Don't create statement wrapper & don't use step() → Form Manager should use executeStep() instead of step()
Created attachment 402634 [details] [diff] [review]
Patch v0.1
Assignee: nobody → paul
Status: NEW → ASSIGNED
Attachment #402634 - Flags: review?(dolske)
Attachment #402634 - Flags: review?(dolske) → review+
Pushed http://hg.mozilla.org/mozilla-central/rev/cead80fe52d8
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Comment on attachment 402634 [details] [diff] [review]
Patch v0.1

I'd like to take this on 1.9.2, mainly to help reduce future patch merge headaches. Should be ultra low-risk, and has plenty of existing test coverage.
Attachment #402634 - Flags: approval1.9.2?
Comment on attachment 402634 [details] [diff] [review]
Patch v0.1

approval1.9.2 requests aren't currently being monitored, since we're nearing RC freeze and there are too many outstanding requests, so I'm clearing this request. Feel free to re-request approval if you are confident that it's worth drivers' time to consider whether this non-blocker needs to land for 1.9.2 at this stage.
Attachment #402634 - Flags: approval1.9.2?
You need to log in before you can comment on or make changes to this bug.