Closed
Bug 518611
Opened 15 years ago
Closed 15 years ago
Form Manager should use executeStep() instead of step()
Categories
(Toolkit :: Form Manager, defect)
Toolkit
Form Manager
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: zpao, Assigned: zpao)
References
Details
Attachments
(1 file)
|
3.30 KB,
patch
|
Dolske
:
review+
|
Details | Diff | Splinter Review |
Bug 452897 made it so that statements are automatically wrapped. step() was deprecated in favor of executeStep().
|
Assignee | |
Updated•15 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Summary: Satchel Storage usage changes: Don't create statement wrapper & don't use step() → Form Manager should use executeStep() instead of step()
|
|
Assignee | |
Comment 1•15 years ago
|
||
|
||
Updated•15 years ago
|
Attachment #402634 -
Flags: review?(dolske) → review+
|
|
Assignee | |
Comment 2•15 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/cead80fe52d8
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
|
|
||
Comment 3•15 years ago
|
||
Comment on attachment 402634 [details] [diff] [review] Patch v0.1 I'd like to take this on 1.9.2, mainly to help reduce future patch merge headaches. Should be ultra low-risk, and has plenty of existing test coverage.
Attachment #402634 -
Flags: approval1.9.2?
|
||
Comment 4•15 years ago
|
||
Comment on attachment 402634 [details] [diff] [review] Patch v0.1 approval1.9.2 requests aren't currently being monitored, since we're nearing RC freeze and there are too many outstanding requests, so I'm clearing this request. Feel free to re-request approval if you are confident that it's worth drivers' time to consider whether this non-blocker needs to land for 1.9.2 at this stage.
Attachment #402634 -
Flags: approval1.9.2?
You need to log in
before you can comment on or make changes to this bug.
Description
•