518632 - Remove embedding/config/

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: Packaging, defect)

Description

[Phil Ringnalda (:philor)]

From bug 515777 comment 11:

[[[
embedding/config must be removed. Camino will need to use standard
XULRunner-type packaging if they have any hope of using -central.
]]]

And since maintenance of bits of it like the packaging manifests has been utterly random for as long as I've been around, anyone else trying to use it has probably been pretty screwed for years. For bonus points, that should let us not only graveyard this Bugzilla component, but also MFC Embed (last bug filed in 2006), since if it hypothetically still could be built, it would be built by embedding/config/.

Comment 1

[Phil Ringnalda (:philor)]

Blergh, I forgot that one of the pretty screwed things using it is codesighs. Don't suppose I'll be able to get away with just breaking its current useless state by removing the manifests it foolishly uses, as a spur to someone to make it actually useful, will I?

Comment 2

[Benjamin Smedberg]

You mean the "embedding codesize" number? That's meaningless and should be removed too. The correct embedding codesize number is just codesize for XULRunner tree.

Comment 3

[Phil Ringnalda (:philor)]

Yeah, despite having written the patch to stop producing it for the Fx tinderbox, I'd forgotten that it's a separate pair of scripts that can just get the axe.

Comment 4

[Phil Ringnalda (:philor)]

Attachment: party.start()

I was going to mull over some other things which look like they've been dead for years by virtue of depending on basebrowser.* not being broken, but then I noticed that I got bit-rotted by Mitch having spent the time to patch broken and useless stuff, so let's just go with this and I can get more in other bugs later. 

This is embedding/config/* and the makefile in toolkit-makefiles.sh, plus tools/codesighs/basesummary.*.bash (which can conveniently be removed without needing to change any docs, since they were utterly, absolutely undocumented other than vaguely internally), plus embedding/browser/activex/src/install/ since it both depends on basebrowser-win and is scary, being an installer that hasn't been touched in forever ("$moz_major_version=1; $moz_minor_version=5;" according to build.pl).

Comment 5

[Boris Zbarsky [:bzbarsky]]

Please cc the camino maintainers here (and maybe on bug 515777)?  Or at least post to the relevant mailing list/newsgroup?  Or something other than silently breaking them?

Comment 6

[Stuart Morgan]

> Or something other than silently breaking them?

Thanks for thinking of us, but unfortunately that ship sailed back during 1.9.1 development. At this point our assumption is that going past 1.9.0 (assuming the embedding layer even works these days) would require creating our build/packaging/embedding setup essentially from scratch, so individual changes don't really matter to us anymore.

Comment 7

[Benjamin Smedberg]

Comment on attachment 403081 [details] [diff] [review]
party.start()

The rest of embedding/browser/activex remains, right? You just removed the bits that create an installer and can't possibly work?

Comment 8

[Phil Ringnalda (:philor)]

Right, just activex/src/installer/*, which hypothetically makes an installer for the GRE as it was around 2004, with most of a Gecko minus some essential bits, and minus MathML and SVG, but plus wallet.

Comment 9

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/mozilla-central/rev/6c4f06ec0300