Closed
Bug 518706
Opened 16 years ago
Closed 16 years ago
NJ merge: more Assembler/Nativei386 odds and ends
Categories
(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: n.nethercote, Assigned: rreitmai)
References
Details
Attachments
(2 files)
|
15.45 KB,
patch
|
rreitmai
:
review+
|
Details | Diff | Splinter Review |
|
8.64 KB,
patch
|
Details | Diff | Splinter Review |
This patch absorbs various good changes from TraceMonkey:
- Replaces some C lib calls with their VMPI equivalents.
- Removes some unnecessary whitespace at ends of lines, presumably caused by
cutting and pasting.
- Adds an assertion in Nativei386.cpp.
- Does a handful of won't-change-the-meaning type changes and variable
renamings.
- Removes a debug_only() wrapper from a switch default case because it
causes lots of warnings with GCC for optimized builds. Since the default
case only contains a NanoAssert(0), the code generated shouldn't be affected.
- Uses ARGSIZE_MASK_ANY in a couple of places where it was missed.
Compiles cleanly, but untested.
Attachment #402698 -
Flags: review?(rreitmai)
|
Assignee | |
Updated•16 years ago
|
Attachment #402698 -
Flags: review?(rreitmai) → review+
|
|
Assignee | |
Comment 1•16 years ago
|
||
first patch didn't apply cleanly to redux head
|
|
Assignee | |
Comment 2•16 years ago
|
||
pushed attachment 403828 [details] [diff] [review] http://hg.mozilla.org/tamarin-redux/rev/89794e965133
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Comment 3•16 years ago
|
||
Resolved fixed engineering / work item that has been pushed. Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•