Closed Bug 518706 Opened 15 years ago Closed 15 years ago

NJ merge: more Assembler/Nativei386 odds and ends

Categories

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: n.nethercote, Assigned: rreitmai)

References

Details

Attachments

(2 files)

Attached patch patchSplinter Review
This patch absorbs various good changes from TraceMonkey:

- Replaces some C lib calls with their VMPI equivalents.

- Removes some unnecessary whitespace at ends of lines, presumably caused by
  cutting and pasting.

- Adds an assertion in Nativei386.cpp.

- Does a handful of won't-change-the-meaning type changes and variable
  renamings.

- Removes a debug_only() wrapper from a switch default case because it
  causes lots of warnings with GCC for optimized builds.  Since the default
  case only contains a NanoAssert(0), the code generated shouldn't be affected.

- Uses ARGSIZE_MASK_ANY in a couple of places where it was missed.

Compiles cleanly, but untested.
Attachment #402698 - Flags: review?(rreitmai)
Attachment #402698 - Flags: review?(rreitmai) → review+
Attached patch fixupSplinter Review
first patch didn't apply cleanly to redux head
pushed attachment 403828 [details] [diff] [review] http://hg.mozilla.org/tamarin-redux/rev/89794e965133
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Resolved fixed engineering / work item that has been pushed.  Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: