518714 - First-run add-ons links should scroll manager to "Get Add-ons" section

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Madhava Enros [:madhava]]

There are two links/buttons on the First Run page that open the Add-ons Manager.  One is to let users get the weave add-on (it searches for it) and the other just takes the user to the Get Add-ons section without a search.

In both cases, when the Add-ons Manager opens, is should be scrolled down to the "Get Add-ons" section, because that's the section of interest.

Comment 2

[Madhava Enros [:madhava]]

Also -- in the case of the "Get the Weave Add-on" link/button, the string "weave" should be in the search field of the Get Add-ons section, so that a user can cancel out post install and look for other add-ons.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: followup

Applies on top of the previous patch, and fixes two minor bugs:
- makes sure we scroll if we don't find any results
- makes sure we scroll if we end up filtering one of the results due to it having an unsafe URI

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Attachment: real followup

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 404676 [details] [diff] [review]
real followup

>diff --git a/chrome/content/extensions.js b/chrome/content/extensions.js

>+    var foundItem = null;

changed this to "false" locally

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Pushed with that: https://hg.mozilla.org/mobile-browser/rev/be88a30e32e1

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 404676 [details] [diff] [review]
real followup

maybe we should give the message rows an ID so we can get them even if we don't call displaySectionMessage

Comment 9

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2b1pre) Gecko/20091006 Fennec/1.0a3


and

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20091006
Fennec/1.0b4

Comment 10

[Jaya]

Added to Litmus:
https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=9836

Comment 11

[Jaya]

Test added to litmus with above link hence updating the in-litmus flag