First-run add-ons links should scroll manager to "Get Add-ons" section

VERIFIED FIXED in fennec1.0b5

Status

Firefox for Android Graveyard
General
VERIFIED FIXED
9 years ago
5 years ago

People

(Reporter: madhava, Assigned: Gavin)

Tracking

Trunk
fennec1.0b5
Bug Flags:
in-litmus +

Details

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
(Reporter)

Comment 1

9 years ago
There are two links/buttons on the First Run page that open the Add-ons Manager.  One is to let users get the weave add-on (it searches for it) and the other just takes the user to the Get Add-ons section without a search.

In both cases, when the Add-ons Manager opens, is should be scrolled down to the "Get Add-ons" section, because that's the section of interest.
Blocks: 477109
tracking-fennec: --- → ?
Summary: First run add-on buttons/links should scroll down to → First-run add-ons links should scroll manager to "Get Add-ons" section
(Reporter)

Comment 2

9 years ago
Also -- in the case of the "Get the Weave Add-on" link/button, the string "weave" should be in the search field of the Get Add-ons section, so that a user can cancel out post install and look for other add-ons.
Created attachment 402721 [details] [diff] [review]
patch
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #402721 - Flags: review?(mark.finkle)
Attachment #402721 - Flags: review?(mark.finkle) → review+
Created attachment 404675 [details] [diff] [review]
followup

Applies on top of the previous patch, and fixes two minor bugs:
- makes sure we scroll if we don't find any results
- makes sure we scroll if we end up filtering one of the results due to it having an unsafe URI
Attachment #402721 - Attachment is obsolete: true
Attachment #404675 - Flags: review?(mark.finkle)
Created attachment 404676 [details] [diff] [review]
real followup
Attachment #404675 - Attachment is obsolete: true
Attachment #404676 - Flags: review?(mark.finkle)
Attachment #404675 - Flags: review?(mark.finkle)
Comment on attachment 404676 [details] [diff] [review]
real followup

>diff --git a/chrome/content/extensions.js b/chrome/content/extensions.js

>+    var foundItem = null;

changed this to "false" locally
Pushed with that: https://hg.mozilla.org/mobile-browser/rev/be88a30e32e1
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → B5
Comment on attachment 404676 [details] [diff] [review]
real followup

maybe we should give the message rows an ID so we can get them even if we don't call displaySectionMessage
Attachment #404676 - Flags: review?(mark.finkle) → review+
verified FIXED on builds:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2b1pre) Gecko/20091006 Fennec/1.0a3


and

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20091006
Fennec/1.0b4
Status: RESOLVED → VERIFIED
Flags: in-litmus?

Comment 11

8 years ago
Test added to litmus with above link hence updating the in-litmus flag
Flags: in-litmus? → in-litmus+
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.