518768 - Rationalize autosync logging

Status: RESOLVED WORKSFORME

(MailNews Core :: Networking: IMAP, defect)

Description

[David Ascher (:davida)]

The autosync code is complex, and hard to debug. It doesn't help that the current logging is #ifdef-driven, making it impossible for users to turn on logging.  Furthermore, the logging messages, when enabled, are quite hard to understand.

A phase 1 improvement would be to use PR_LOG instead of #ifdef'ed printfs.

A phase 2 would be to review the code to make sure that the logging statements are as helpful as possible.

It might be nice to do phase 1 in time for TB3 to help troubleshoot problems in the wild.

Comment 1

[Wayne Mery (:wsmwk)]

glad you filed the bug. yes! I could use autosync logging this very moment.

Comment 2

[David :Bienvenu]

NSPR_LOG_MODULES=ImapAutoSync:5 will give you autosync logging in tomorrow's build.

In bug 517256, I've cleaned up the logging a little bit, and added some logging of interesting events (like when it actually tries to download message bodies :-) ) and when syncing has been paused/resumed.  I've also got rid of 0 length (i.e., deleted) messages from the queue and hence the log, and no select folders. But a lot more cleanup is still needed.

Comment 3

[Ludovic Hirlimann [:Usul]]

Removing myslef on all the bugs I'm cced on. Please NI me if you need something on MailNews Core bugs from me.

Comment 4

[Wayne Mery (:wsmwk)]

FYI

Comment 5

[gene smith]

I added a lot of MOZ_LOG()s to the autosync files so I could follow the flow and understand what it is doing. So, at least from my point of view, this bug is fixed.