518851 - urls.py imports settings.py directly

Status: RESOLVED FIXED

(Webtools :: ISPDB Server, defect)

Description

[Eric Henry]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US) AppleWebKit/532.0 (KHTML, like Gecko) Chrome/4.0.211.7 Safari/532.0
Build Identifier: 

urls.py imports settings.py directly which overrides the django --settings option.

Reproducible: Always

Steps to Reproduce:
Checkout source, run.
Actual Results:  
imports settings.py instead of whatever was specified with the --settings option...

Expected Results:  
importing the file specified by the --settings option

Comment 1

[Eric Henry]

Attachment: patch to use django.conf.settings

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 402849 [details] [diff] [review]
patch to use django.conf.settings

>Index: urls.py
>-import settings
>+from django.conf import settings

Looks good to me.

Later,
Blake.

Comment 3

[Philippe M. Chiasson (:gozer)]

Carefull, that patch probably had win32 line endings

$> cat attachment.cgi\?id\=402849 | patch -p0
(Stripping trailing CRs from patch.)

Committed revision 53424.