Closed
Bug 518851
Opened 16 years ago
Closed 16 years ago
urls.py imports settings.py directly
Categories
(Webtools :: ISPDB Server, defect)
Webtools
ISPDB Server
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ehenry5, Assigned: ehenry5)
Details
Attachments
(1 file)
|
390 bytes,
patch
|
bwinton
:
review+
gozer
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US) AppleWebKit/532.0 (KHTML, like Gecko) Chrome/4.0.211.7 Safari/532.0
Build Identifier:
urls.py imports settings.py directly which overrides the django --settings option.
Reproducible: Always
Steps to Reproduce:
Checkout source, run.
Actual Results:
imports settings.py instead of whatever was specified with the --settings option...
Expected Results:
importing the file specified by the --settings option
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #402849 -
Flags: review?
|
|
Assignee | |
Updated•16 years ago
|
Attachment #402849 -
Flags: review? → review?(bwinton)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 402849 [details] [diff] [review]
patch to use django.conf.settings
>Index: urls.py
>-import settings
>+from django.conf import settings
Looks good to me.
Later,
Blake.
Attachment #402849 -
Flags: review?(bwinton) → review+
|
|
Assignee | |
Updated•16 years ago
|
Attachment #402849 -
Flags: review?(gozer)
|
|
||
Updated•16 years ago
|
Attachment #402849 -
Flags: review?(gozer) → review+
|
|
||
Updated•16 years ago
|
Assignee: nobody → ehenry5
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
|
||
Comment 3•16 years ago
|
||
Carefull, that patch probably had win32 line endings
$> cat attachment.cgi\?id\=402849 | patch -p0
(Stripping trailing CRs from patch.)
Committed revision 53424.
|
||
Updated•13 years ago
|
Component: ispdb → ISPDB Server
Product: Mozilla Messaging → Webtools
You need to log in
before you can comment on or make changes to this bug.
Description
•