518868 - revise identity panel styling

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Madhava Enros [:madhava]]

There's a recent screenshot of the current styling here:  http://www.flickr.com/photos/madhava_work/3951041188/

A couple of related issues:
- lack of definition to the bottom edge of the panel (the grey just stops)
- the section-border light-gray line is a little flat/clumsy
- there's been some feedback about the oddness of it being flat except for the one search-provider button

Comment 1

[Sean Martell]

Revised styling using shadow to "tuck under" address bar area.

http://mozilla.seanmartell.com/fennec/larry_7.png

The horizontal rule separating the top box from the lower is a 2 color line consisting of: 

light CSS line: 52555a
dark CSS line: 212429

Shadow file attached as 800x20 PNG.

Comment 2

[Sean Martell]

Attachment: Panel Shadow (for Larry)

Comment 3

[Madhava Enros [:madhava]]

These changes address the weird flatness issues, I think.

We may still want to have the search provider button include the text "Add Search:"

The shadow along the bottom of the panel should use the same shadow mechanism as our other panels and alert popups.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: normal mode

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: With search provider

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

This patch is fine, but doesn't use the shadow separating the larry panel from the URLBar. Personally, I wouldn't mind just using the separator line, but I think Madhava would like the shadow.

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch with larry shadow

Add the larry shadow

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

with changes:
* larry-shadow.png -> panel-shadow.png
* added the same shadow to the bookmark panel

pushed:
https://hg.mozilla.org/mobile-browser/rev/3141d3fad77a

Comment 10

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b3pre) Gecko/20091111 Firefox/3.6b2pre Fennec/1.0b5

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091111 Firefox/3.7a1pre Fennec/1.0b5