Closed Bug 518868 Opened 11 years ago Closed 10 years ago

revise identity panel styling

Categories

(Firefox for Android Graveyard :: General, defect, P1)

defect

Tracking

(fennec1.0+)

VERIFIED FIXED
fennec1.0
Tracking Status
fennec 1.0+ ---

People

(Reporter: madhava, Assigned: vingtetun)

Details

(Whiteboard: [polish])

Attachments

(4 files, 1 obsolete file)

There's a recent screenshot of the current styling here:  http://www.flickr.com/photos/madhava_work/3951041188/

A couple of related issues:
- lack of definition to the bottom edge of the panel (the grey just stops)
- the section-border light-gray line is a little flat/clumsy
- there's been some feedback about the oddness of it being flat except for the one search-provider button
tracking-fennec: --- → ?
Whiteboard: [polish]
Priority: -- → P1
tracking-fennec: ? → 1.0+
Revised styling using shadow to "tuck under" address bar area.

http://mozilla.seanmartell.com/fennec/larry_7.png

The horizontal rule separating the top box from the lower is a 2 color line consisting of: 

light CSS line: 52555a
dark CSS line: 212429

Shadow file attached as 800x20 PNG.
These changes address the weird flatness issues, I think.

We may still want to have the search provider button include the text "Add Search:"

The shadow along the bottom of the panel should use the same shadow mechanism as our other panels and alert popups.
Attached patch Patch (obsolete) — Splinter Review
Assignee: madhava → 21
Attachment #410391 - Flags: review?(mark.finkle)
This patch is fine, but doesn't use the shadow separating the larry panel from the URLBar. Personally, I wouldn't mind just using the separator line, but I think Madhava would like the shadow.
Add the larry shadow
Attachment #410391 - Attachment is obsolete: true
Attachment #411420 - Flags: review?(mark.finkle)
Attachment #410391 - Flags: review?(mark.finkle)
Attachment #411420 - Flags: review?(mark.finkle) → review+
with changes:
* larry-shadow.png -> panel-shadow.png
* added the same shadow to the bookmark panel

pushed:
https://hg.mozilla.org/mobile-browser/rev/3141d3fad77a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b3pre) Gecko/20091111 Firefox/3.6b2pre Fennec/1.0b5

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091111 Firefox/3.7a1pre Fennec/1.0b5
Status: RESOLVED → VERIFIED
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: --- → Post-B5
You need to log in before you can comment on or make changes to this bug.