518936 - Socorro UI - advanced search accepts datetimes but only uses dates

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[K Lars Lohn [:lars] [:klohn]]

The advanced search in the "Occurs before" field accepts a datetime down to the minute while the next field, "Within the last", has a resolution down to an hour.  In fact, when actually doing a search any time component given to the "Occurs before" field is truncated.

For example: 
  Occurs before <- 09/22/2009 11:00:00
  With in the last  <- 1 Hour

returns crashes with datetimes ranging between
2009-09-21 23:00:00 and 2009-09-22 00:00:00

However, it tags the query results with original entry: "Results within 1 hours of 09/22/2009+11:00:00."

Comment 1

[K Lars Lohn [:lars] [:klohn]]

Attachment: an sql change that doesn't solve the problem like I expected

I've been looking at this because with the number of crashes/signatures under scrutiny right now, this is going to be an important tool to locate the minidumps for the developers.  

On initial inspection, it appears that the problem is with a string being cast to type DATE within an SQL statment in .../applications/models/common.php  Yet changing it to "TIMESTAMP WITHOUT TIME ZONE" doesn't have the result that I would expect.  See the attachment

Comment 2

[K Lars Lohn [:lars] [:klohn]]

Ozten, could you take a look at this when you've got the chance?

Comment 4

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Attachment: Patch 1 for 518936

Lars - I started working with the sql you recommended in the previous attachment, and it seems to be returning the results properly.

Querying for results from 04/10/2010 11:25:00 return results for 11:25, 11:24, etc. and everything looks proper to me.  Take a look and make sure that works for you as well.

I've updated the UI in the advanced search page to be a little more descriptive of the expected results set.

Comment 5

[Austin King [:ozten]]

Comment on attachment 439628 [details] [diff] [review]
Patch 1 for 518936

Looks good! Nice work.

Note: this patch is out of date against trunk.

Comment 6

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Thanks Austin... Committing...

==

Sending        application/controllers/query.php
Sending        application/models/common.php
Sending        application/views/common/query_form.php
Sending        css/screen.css
Sending        js/socorro/query.js
Transmitting file data .....
Committed revision r1972.

Comment 7

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Looks good from my end.