519001 - "Edit Security Exceptions" button misaligned in prefs

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Somehow it's lower, and we missed it. :(

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Fix

Well, we can fix it in 2.1 at least :(

Comment 2

[Stuart Morgan]

Ugh, I must have jostled it somehow after adding it.

We could land the fix for English just before shipping 2.0, so most users will get the fix but we won't disrupt the localizers. We could also let localizers know, and those who are still working can adjust the button placement themselves, so at least some other languages would get fixed.

Comment 3

[Stuart Morgan]

Comment on attachment 403007 [details]
Fix

sr=smorgan

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #2)
> Ugh, I must have jostled it somehow after adding it.

No, it was murph or I adding the safebrowsing pref and hint text :(  You sr'd the nib, though ;)

> We could land the fix for English just before shipping 2.0, so most users will
> get the fix but we won't disrupt the localizers. We could also let localizers
> know, and those who are still working can adjust the button placement
> themselves, so at least some other languages would get fixed.

Yeah, I think that sounds possible; in fact, I think we could land it "now" as opposed to "just before 2.0", since it's not fundamentally altering the nib (item names or tags) or changing a string, and it's a trivial adjustment localizers can make (and some may already have done so).

Marcello, does that seem OK to you?  (The button has to move up 2px, I think; I'm not at the right computer to check anymore.)

Comment 5

[Marcello Testi]

I have checked mine and it was aligned and I didn't remember I did. I guess nearly every localizer has had the chance to fix it (and thay've probably done it), since this is one of those buttons that end up resized and need to be moved around after translation.
We can send a warning to the list and we can also open a new [l10n] bug assigned to me, so I will check the nibs in incoming 2.0 l10ns before shipping and fix the misaligned buttons.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #4)
> (The button has to move up 2px, I think;

Yes, up 2px.

(In reply to comment #5)
> We can send a warning to the list and we can also open a new [l10n] bug
> assigned to me, so I will check the nibs in incoming 2.0 l10ns before shipping
> and fix the misaligned buttons.

OK, sounds good.

Landed on cvs trunk and CAMINO_2_0_BRANCH.