519186 - drag & drop in bookmarks menu does not correctly update the view

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Marco Bonardo [:mak]]

This is most likely regression from bug 498130

1. create a new profile
2. open bookmarks menu
3. drag "Get bookmarks add-ons" below the next separator

result:
4. item moves to a "random" position

expected:
4. correct position for drop

Comment 1

[Marco Bonardo [:mak]]

sounds like it is not taking in count the _startMarker

Comment 2

[Marco Bonardo [:mak]]

indeed in nodeMoved popup.insertBefore(nodeElt, popup.childNodes[aNewIndex]);
should most likely do the same as nodeInserted
let index = popup._startMarker + 1 + aIndex;

Comment 3

[Asaf Romano (gone)]

marco: I cannnot test this, but I'll gladly review ;)

Comment 4

[Marco Bonardo [:mak]]

yeah, taking.

Comment 5

[Marco Bonardo [:mak]]

Attachment: patch v1.0

Comment 6

[Asaf Romano (gone)]

Comment on attachment 403484 [details] [diff] [review]
patch v1.0

r=mano. Thanks Marco!

Comment 8

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/c2906e26f75a

Comment 9

[Marco Bonardo [:mak]]

the patch has been merged by Mano in 1.9.2 landing for bug 498130. so this is fixed on that branch too.

Comment 10

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2b1pre) Gecko/20091009 Namoroka/3.6b1pre 
and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091009 Namoroka/3.7a1pre