51921 - SSL/IMAP in netscape6 mail does not show lock icon as locked

Status: VERIFIED FIXED

(MailNews Core :: Networking: IMAP, defect, P3)

Description

[nitinp]

I have SSL/IMAP enabled in my netscape6 build of 20000908. When I open the mail
box and login to the server the lock still remains open and does not lock.

Comment 1

[nitinp]

adding keyword nsbeta3 and nominating for nsbeta3+

Comment 2

[David P. Drinan]

SSL/IMAP is not a required feature of Netscape 6. Marking this bug nsbeta3-.

Comment 3

[Stuart Parmenter]

you do realize that while it might not be a "required" feature for NS6, it is in
the product and people will probably use it.

Comment 4

[David P. Drinan]

We would like to fix this bug as well. However, due to resource constraints in 
the crypto team, we have to focus all of our energy on fixing the features that 
we have committed to.

Comment 5

[John Unruh]

Marking invalid, since SSL/IMAP is not supported yet.

Comment 6

[Stuart Parmenter]

huh?  we support ssl/imap

Comment 7

[John G. Myers]

This is now a mailnews bug.  The IMAP (mock?) channel needs to implement the 
GetSecurityInfo() method, returning the securityInfo of the underlying 
transport.  One also has to worry about preserving the securityinfo in any 
cache.  See nsHTTPChannel::GetSecurityInfo()

Comment 8

[John G. Myers]

Reassign to owner of component.

Comment 9

[Scott MacGregor]

accepting...adding mail3 keyword

Comment 10

[scottputterman]

marking nsbeta1+ and moving to mozilla0.8

Comment 11

[Scott MacGregor]

There are two parts to this bug:
1) the mail window needs to create a secure browser UI instance to monitor the
status of our lock icon. (why psm called it a browser UI I don't know since many
apps need to use it).

2) As John mentioned, we need to implement GetSecurityInfo on the mock channel.
In addition, the imap channel needs to pass the security info for it's transport
layer onto the mock channel and the memory cache entry.

Posting the fixes right now. 

Comment 12

[Scott MacGregor]

Attachment: proposed fix for imap

Comment 13

[Scott MacGregor]

This patch is working well for me with one big exception. Everything shows up as
mixed content =). This is because the secure browser UI is getting notifications
from the JAR url we run for the throbber.

John, do you know off the top of your head why the throbber doesn't cause this
same problem in the browser?

I'm still digging into this part. 

Comment 14

[John G. Myers]

You're running into bug 48515.  Look in nsSecureBrowserUIImpl.cpp for a comment 
mentioning 48515 to see how I work around the problem.  Either that workaround 
will have to be extended to handle jar URLs or bug 48515 will have to be fixed.

Comment 15

[John G. Myers]

...either that or you're putting the SecureBrowserUI at the wrong level.

Comment 16

[Scott MacGregor]

heh silly me, I was setting the secure browser UI at the top instead of on the
content window. This patch is good to go pending reviews....

including this additional change:
secureUI.init(_content, securityIcon); (the first argument used to be window)

Comment 17

[David :Bienvenu]

sr=bienvenu

Comment 18

[Scott MacGregor]

fix checked in. 

Comment 19

[esther]

Using builds dated 3-05-01 on winme, mac and linux and setting SSL in a mail
account, I now see a locked icon on the server icon in the folder pane.  I also
see an unlock icon in the status bar representing the message window, it stays
unlocked until I open a mail message.  If this status bar lock represents the
opened message then we need one in the stand alone message window.  Let me know
if you want a new bug for that window before I verify this.

Comment 20

[esther]

verifying this since the original bug as stated is fixed and has been since 3-6

Comment 21

[Antonio Lam]

I tried with 2001070606_0.9.2 build from 
ftp://sweetlou.mcom.com/products/client/6.x/windows/32bit/x86

As it mentioned in the last two comments, With SSL/IMAP enabled, I am now able 
to see the locked icon for the messaging server in the folder pane. 

But, I still see the unlocked icon in the status bar from the message pane when 
I click on the message's header in the upper pane. I also tried to double click 
the message to show it in different window, and I don't see lock icon in the 
status bar either. 

It looks like to me that it is only a partial fix (locked icon on the folder 
pane, but unlocked icon in the status bar). Any comments on this?