519348 - Blocklist radhslib.dll, an unsupported add-on

Status: RESOLVED FIXED

(Toolkit :: Blocklist Policy Requests, defect, P2)

Description

[Carsten Book [:Tomcat]]

From the Topcrash Stats:

http://crash-stats.mozilla.com/report/list?product=Firefox&version=Firefox%3A3.5.3&platform=windows&query_search=signature&query_type=exact&query=&date=&range_value=1&range_unit=weeks&do_query=1&signature=radhslib.dll%400x3b6f

radhslib.dll is a part of the Naomi web filter by Radiant Morning Technologies, according to some forums. Will test there.

Comment 1

[Damon Sicore (:damons)]

Blocking 3.6+ per CrashKill effort.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Marking all topcrash bugs as P2 (3.6 release blockers, but not 3.6b1 blockers)

Comment 3

[Samuel Sidler (old account; do not CC)]

Assigning to Tomcat.

Comment 4

[Carsten Book [:Tomcat]]

while running this webfilter, the vm got very slow (also its an since 2006 or so unsupported product anymore), but still no crash so far

Comment 5

[Samuel Sidler (old account; do not CC)]

If this product is no longer under development and there's clearly not a way for us to get the developers to fix it, we should blocklist the dll. All present at the CrashKill meetings agree.

-> addons.mozilla.org::Blocklisting

Comment 6

[Samuel Sidler (old account; do not CC)]

Oh, the unsupported comment is based on http://www.radiance.m6.net/ via Tomcat.

Comment 7

[Samuel Sidler (old account; do not CC)]

morgamic: Can we get this on the list for the next Blocklist update? Maybe Friday or so? I'm not sure how regularly we do them.

Comment 8

[Matthias Versen [:Matti]]

IS this installed as addon or as LSP which can not be blocked ?

Comment 9

[Michael Morgan [:morgamic]]

Blocklist "radhslib.dll" all versions, all apps?

Comment 10

[Johnathan Nightingale [:johnath]]

Can this be blocked at the plugin level, or only as a DLL? Tomcat - you ran this in a VM, does that mean there is an associated plugin?  Or does this just drop in the components directory?

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Tomcat, can we get an answer to comment 10? We need to know if this can be blocked at the plugin level or not; if not, we need to patch the code to block it at the DLL level.

Comment 12

[Carsten Book [:Tomcat]]

(In reply to comment #10)
> Can this be blocked at the plugin level, or only as a DLL? Tomcat - you ran
> this in a VM, does that mean there is an associated plugin?  Or does this just
> drop in the components directory?

Retested this and seems its DLL Level - DLL was in  C:\Program Files\rnamfler
 and no plugin listed in Firefox

Comment 13

[Johnathan Nightingale [:johnath]]

Attachment: Blocklist unversioned instances of radhslib.dll

DLL blocklist candidate - taking.

The crash dumps I'm looking at all report no version for this DLL, so the patch uses the UNVERSIONED macro.

Comment 14

[Johnathan Nightingale [:johnath]]

http://hg.mozilla.org/mozilla-central/rev/59ea568ba8a4

(with a terrible checkin comment that didn't include an r=vlad - sorry world.)

Comment 15

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Johnath: Do we want this on the 1.9.2 branch?

Comment 16

[Johnathan Nightingale [:johnath]]

(In reply to comment #15)
> Johnath: Do we want this on the 1.9.2 branch?

Unless the crashes have disappeared on their own, I generally think we should take any blocklist addition on branches. They don't introduce code risk, they mitigate topcrashes (by definition!), and nothing about the evaluation process we go through here is branch-specific.

Of course, first we need a way to ask for branch approval...

Comment 17

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

It's currently the #107 topcrasher

Comment 18

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 422268 [details] [diff] [review]
Blocklist unversioned instances of radhslib.dll

And Dan just installed the flag, so requesting approval

Comment 19

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 422268 [details] [diff] [review]
Blocklist unversioned instances of radhslib.dll

a1922=beltzner

Comment 20

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checked in for 1.9.2.2

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/a71ea96b30a8

Comment 22

[Al Billings [:abillings - ex-MoCo]]

Verified for 1.9.2 by looking at checked in source.