Closed Bug 519383 Opened 15 years ago Closed 15 years ago

NJ merge: yet more Assembler/backend stuff

Categories

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect)

Product:
Tamarin Graveyard
Component:
Baseline JIT (CodegenLIR)
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: n.nethercote, Assigned: rreitmai)

References

Details

Attachments

(1 file, 1 obsolete file)

patch
7.08 KB, patch
edwsmith
: review+
Details | Diff | Splinter Review
Attached patch patch (obsolete) — — Splinter Review 
This patch absorbs various changes from TM:

- patch(): allow for the guard having been eliminated.

- Remove nFrameRestore() declaration, which is dead.

- Allow for four args in registers for x86_64, which happens on Windows.

- Get rid of the one use of _WIN64 in Nanojit, use _MSC_VER instead.

- Avoid tabs and extraneous whitespace in the __SUNPRO_CC code (this syncs
  with a pending patch for TM).

Compiles cleanly, but untested.
Attachment #403407 - Flags: review?(edwsmith)
Attached patch patch — — Splinter Review 
Fixed up more _WIN64/_MSC_VER #ifdefs -- because we might want to compile with GCC on Windows, we need to use _WIN64 for x86-64 Windows ABI issues, and _MSC_VER for MSVC vs. GCC issues.
Attachment #403407 - Attachment is obsolete: true
Attachment #403421 - Flags: review?(edwsmith)
Attachment #403407 - Flags: review?(edwsmith)
Attachment #403421 - Flags: review?(edwsmith) → review+
Assignee: edwsmith → rreitmai
pushed http://hg.mozilla.org/tamarin-redux/rev/2f0120218432
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Resolved fixed engineering / work item that has been pushed.  Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: