UMR in XPCWrappedNative::CallMethod

RESOLVED FIXED

Status

()

Core
XPConnect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Robert Sayre, Assigned: mrbkap)

Tracking

unspecified
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(status1.9.2 beta1-fixed, status1.9.1 .6-fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

8 years ago
looks there's no way this should happen--could be pretty bad.
(Reporter)

Updated

8 years ago
Assignee: nobody → mrbkap
(Reporter)

Comment 1

8 years ago
Created attachment 403547 [details] [diff] [review]
valgrind stack
(Reporter)

Comment 2

8 years ago
==4856== Conditional jump or move depends on uninitialised value(s)
==4856==    at 0x52C5DCA: XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode) (xpcwrappednative.cpp:2583)
==4856==    by 0x52CACC1: XPC_WN_CallMethod(JSContext*, JSObject*, unsigned int, long*, long*) (xpcwrappednativejsops.cpp:1590)
==4856==    by 0x6565904: js_Invoke (jsinterp.cpp:1386)
==4856==    by 0x655558E: js_Interpret (jsinterp.cpp:5179)
==4856==    by 0x656441D: js_Execute (jsinterp.cpp:1622)
==4856==    by 0x652C9B4: JS_EvaluateUCScriptForPrincipals (jsapi.cpp:5145)
==4856==    by 0x652DC0B: JS_EvaluateScriptForPrincipals (jsapi.cpp:5109)
==4856==    by 0x403C17: ProcessArgs(JSContext*, JSObject*, char**, int) (xpcshell.cpp:1079)
==4856==    by 0x4043C4: main (xpcshell.cpp:1739)
==4856==  Uninitialised value was created by a stack allocation
==4856==    at 0x5B430E2: nsBinaryInputStream::ReadBoolean(int*) (nsBinaryStream.cpp:474)
==4856==
(Assignee)

Comment 3

8 years ago
Created attachment 403646 [details] [diff] [review]
Fix

This shouldn't actually affect non-valgrind builds since we don't convert the uninitialized memory to a return value and we also don't have to deallocate it.
Attachment #403646 - Flags: review?(sayrer)
(Reporter)

Comment 4

8 years ago
Comment on attachment 403646 [details] [diff] [review]
Fix

NS_ENSURE_SUCCESS?
Attachment #403646 - Flags: review?(sayrer) → review+
(Assignee)

Comment 5

8 years ago
http://hg.mozilla.org/mozilla-central/rev/cebf1a09f168
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Updated

8 years ago
Attachment #403646 - Flags: approval1.9.2?
Attachment #403646 - Flags: approval1.9.1.5?

Updated

8 years ago
Attachment #403646 - Flags: approval1.9.2? → approval1.9.2+
(Assignee)

Comment 6

8 years ago
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/356efd3ad9af
status1.9.2: --- → beta1-fixed
Comment on attachment 403646 [details] [diff] [review]
Fix

Approved for 1.9.1.5, a=dveditz for release-drivers
Attachment #403646 - Flags: approval1.9.1.5? → approval1.9.1.5+
(Assignee)

Comment 8

8 years ago
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/7d3a8b0689a0
status1.9.1: --- → .6-fixed
You need to log in before you can comment on or make changes to this bug.