519530 - mozilla.org now has the same unvisited and visited link color

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

When visiting pages on mozilla.org (or links on mozilla.org to off-site pages), you can now no longer tell which pages/links you have already visited.

This is annoying because, well, you can now no longer tell which pages/links you have already visited.

Comment 1

[Chris More [:cmore]]

Closing old Mozilla.org website bugs due to them not being relevant to the new Python-based Bedrock system. Re-open if this is a critical bug and should be resolved on the new system too.

Comment 2

[Samuel Sidler (:ss)]

Another great example of investigating a bug (5 seconds of time) to see if it's still relevant...

This is still relevant on the mozilla.org homepage and on subpages like the one in the URL field.

Comment 3

[Samuel Sidler (:ss)]

CCing Chris More to this bug, which he closed prematurely.

Comment 4

[Chris More [:cmore]]

Hi Samuel.

The current Mozilla Sand Stone theme had the same color as both. I talked to Sean Martell and they are working on the link color definitions now and they will be different in the future. Once the new theme is updated on the brand toolkit, Mozilla.org will be updated.

We'll keep this open until that happens.

Thanks

Comment 5

[Chris More [:cmore]]

Sean: Are these link colors resolved in the latest style guide?

Comment 6

[Mike Alexis [:malexis]]

Sean, is this something we still want to change?

Comment 7

[Sean Martell]

I thought when we first applied Sandstone, links were "Fx light blue" and visited were "Fx blue".

Has that changed?

The idea was they turn Fx blue on hover, so a followed link would then have them turn that darker blue as well.

Comment 8

[Craig Cook (:craigcook)]

https://github.com/mozilla/bedrock/blob/master/media/css/sandstone/sandstone.less#L31

There's nothing defined for :visited so it's the same color as unvisited (as the bug states), and looking through the history it seems like this has always been the case. I'm not finding anything specifically about link colors in the styleguide, I think this just fell through the cracks.

It's a very easy change to make and is a small usability win for everyone. Just to clarify:

* Unvisited links should be light blue with no underline. 
* Visited links should be dark blue with no underline. 
* Hovered/focused/active links should be the same dark blue, plus underlined. 

Does that sound right?

Comment 9

[Jennifer Bertsch [:jbertsch]]

Sounds right to me.  Let's do it, Craig!

Comment 10

[Malena Andrade [:malenita]]

Attachment: https://github.com/mozilla/bedrock/pull/2961

Comment 11

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/c16803fe0585ae3334abaee8a26b0178504bafcb
Bug 519530 Adding/updating visited link color.

https://github.com/mozilla/bedrock/commit/bac0e501972f2e68b6e798d3f90f0534a8d39f9d
Merge pull request #2961 from malena/bug-519530-visited-links

Bug 519530 Adding/updating visited link color.