Closed
Bug 519794
Opened 15 years ago
Closed 15 years ago
Add a comment about using PR_strtod
Categories
(Core :: SVG, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jrmuizel, Assigned: jrmuizel)
Details
Attachments
(1 file)
|
660 bytes,
patch
|
jwatt
:
review+
|
Details | Diff | Splinter Review |
The recent regression of tSVG is because PR_strtod got slower because of bug 516396. However, PR_strtod is already slow, so add a comment to the effect incase someone wants to fix it.
|
Assignee | |
Updated•15 years ago
|
Attachment #403837 -
Flags: review?(jwatt)
|
||
Comment 1•15 years ago
|
||
The addition of this comment is obviously a good idea, but since I'm not a peer for NSPR I'm not sure I should review. CC'ing NSPR people:
http://www.mozilla.org/about/owners.html#nspr
|
|
Assignee | |
Comment 2•15 years ago
|
||
(In reply to comment #1)
> The addition of this comment is obviously a good idea, but since I'm not a peer
> for NSPR I'm not sure I should review. CC'ing NSPR people:
>
> http://www.mozilla.org/about/owners.html#nspr
The comment is being added to the svg code though, not NSPR. The comment suggests against using NSPR not trying to optimize it.
|
|
||
Updated•15 years ago
|
Attachment #403837 -
Flags: review?(jwatt) → review+
|
|
||
Comment 3•15 years ago
|
||
Comment on attachment 403837 [details] [diff] [review]
Add a comment about the speed of PR_strtod
Oops. r=me :-) Thanks for adding this!
|
|
Assignee | |
Comment 4•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•13 years ago
|
Assignee: nobody → jmuizelaar
You need to log in
before you can comment on or make changes to this bug.
Description
•