519814 - Fennec - mochitest chrome failure - Unknown Content Dialog

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Doug Turner (:dougt)]

1 failure on toolkit/mozapps/downloads/tests/chrome/test_unknownContentType_dialog_layout.xul (timeout)


Looks like we might not be smart enough to close the dialog.  We probably need to support dialog.cancelDialog()?

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Actually, we don't use a dialog in this case. We use a panel in the main window's XUL.

Comment 2

[Doug Turner (:dougt)]

mark - then the testcase is bogus for fennec and a new one should be made, correct?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

That probably makes the most sense.

Comment 4

[Doug Turner (:dougt)]

joel, what do you want to do about this?  Can you disable it for fennec or write a new test case for us?

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

I am fine disabling this for Fennec.  Not sure the best way to do this.  For other stuff that we have pulled out it is done with the makefile system.  Looking at the similar tests in the mozapps/download folder, do we even need any of these?

http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/downloads/tests/chrome/

Right now our download manager is much more trimmed down than the desktop version.  I would think writing unique tests for this should be browser-chrome since our UI code is in mobile-browser?  I will admit I am not the expert.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #4)
> joel, what do you want to do about this?  Can you disable it for fennec or
> write a new test case for us?

I think we should add a browser-chrome test for fennec

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Filed bug 519826

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

how do we disable feeds and privatebrowsing in mobile?  We should do a similar technique for this chrome directory of tests.

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

so what are the next steps to disable the firefox specific download tests?

Comment 10

[cmtalbert]

I think ideally for tests like this we'd have a manifest stating that it is not compatible with Fennec and should not be run.  However, overhauling the entire mochitest system with such a manifest for every single test is a bit out of the scope of this little bug.  I think we have two solutions here:

1. Post process the test results to show this as an expected failure -- that should already be do-able using the LogCompare tool that Jmaher wrote.
2. Use a makefile define to essentially #ifdef the file out of the makefile for mobile builds.

I tend to prefer option 1 since it keeps things simpler.  However, option 1 depends on logcompare talking to the main tinderbox reporting page or changing the page that all Fennec developers use to check test status to some LogCompare generated page.  Perhaps option 2 is easier in teh short term and we back it out after we have more end to end infrastructure in place.

Comment 11

[BMO Automation]

Closing all opened bug in a graveyard component