Closed
Bug 51985
Opened 26 years ago
Closed 24 years ago
`Go' button should have default button appearance
Categories
(SeaMonkey :: UI Design, defect, P4)
SeaMonkey
UI Design
Tracking
(Not tracked)
RESOLVED
FIXED
Future
People
(Reporter: mpt, Assigned: bhart)
Details
(Keywords: polish, Whiteboard: checklinux)
Attachments
(2 files)
|
4.40 KB,
image/png
|
Details | |
|
865 bytes,
patch
|
stdowa+bugzilla
:
review+
jag+mozilla
:
superreview+
|
Details | Diff | Splinter Review |
Build: 2000090820, Mac OS 9.0 (but this is probably true on other platforms as
well)
When focus is in the location field, the `Go' button (if it is visible) should
have the `default button' appearance (e.g. an extra border), which indicates that
pressing Return/Enter will activate that button.
Sending to German for comment. This seems a little unusual to me, but German
should make the call.
Assignee: hangas → german
| Reporter | ||
Comment 2•26 years ago
|
||
dup of 52036
*** This bug has been marked as a duplicate of 52036 ***
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → DUPLICATE
This is not a dupe of bug 52036. That is concerned with the general appearance
of the 'go' and 'search' buttons in classic. This is concerned with a button
having a default appearance when the location field has focus. REOPENING.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Comment 5•25 years ago
|
||
Suggested summary for clarity: "[Classic][Mac] needs outline around Go button
when focus in location field"
german, comments?
Status: REOPENED → NEW
Summary: [Classic] `Go' button should have default button appearance → `Go' button should have default button appearance
Does that imply toolbar items other than the url bar are focusable? If so this
would be rathole we don't want to enter. Other than that from a usability
perspective if one has the Go button turned on, it is certainly useful feedback
to have it appear the default when a new text is typed in. I fail to see though
why this relates to Classic only. If we think this is the right thing to do the
solution should be theme agnostic.
Keep in mind the Go button turned off by default in Netscape 6.x (so this
applies mostly to Mozilla users), I never believed the button itself was a good
solution. For the longer run we are working on solution to be integrate search
and url bar better. More to be posted shortly.
forwarding to Ben to take a look...
Assignee: german → ben
Comment 8•25 years ago
|
||
(Remember the Go button is important for accessibility reasons, therefore it's
a good solution for some people.)
Gerv
go has nothing to do w/ accessibility. if you type a url, you can press the
enter key
| Reporter | ||
Comment 10•25 years ago
|
||
I am sick and tired of having to go round closing the Explorer Bar for customers
who have entered an URL in Internet Explorer, clicked the `Search' button on the
toolbar under the impression that it was a `Go' button, been confused at the
results, and asked me for help. But at least I am thankful that they're not using
Mozilla or Netscape 6, where this problem is even worse because the `Search'
button is right next to the address field where a `Go' button should be.
When I tell these customers that pressing Enter will take them to the URL they
have typed in, generally they react with surprise. I think giving the `Go' button
the default button appearance when the address field has focus (which Internet
Explorer doesn't do) will *partially* solve this problem, which is why I filed
this bug. Further integrating search with the address field would, of course,
only make the problem worse.
[If this is theme-agnostic, then --> XP Apps: GUI. Small change for high
usability gain --> polish keyword.]
Comment 11•25 years ago
|
||
> When I tell these customers that pressing Enter will take them to the URL they
> have typed in, generally they react with surprise.
I cannot confirm this from Netscape usability testing. Most people intuitively
used the enter key and expected to be taken to the site after having typed in a url.
Updated•25 years ago
|
QA Contact: sairuh → claudius
Updated•25 years ago
|
Status: NEW → ASSIGNED
Priority: P3 → P4
Target Milestone: --- → Future
Comment 12•25 years ago
|
||
This is very useful as I do a lot of copy and pasting URLS from another window
into the location bar, I want to use the mouse to click GO. I dont like having
to lift my hand up to hit enter if I'm already there with the mouse.. I always
have to add it in pref panel after I install a new build because I like using
the mouse more than the keyboard for switching to different tasks in a browser.
Which is way faster than I can hit correct buttons or keyboard combinations..
and a reason I like right-click context menus. Not to mention I bet most Apple
MAC users are more mouse people than keyboard.
-I do this with Tabs, and new windows.. it depends what I wanna do with it.
most frequently copy->paste from Mozilla to Netscape.. or one mozilla build to
another.. or another mozilla navigator window.. if I have too many tabs open, or
If I use one window with tabs for certain related sites and another for say
bugzilla. I'd say make 'Go' default appearance.
Comment 13•25 years ago
|
||
If I do search I will open Google.. or the sidebar.. not enter it into the
location bar.. I guess it depends if you are a novice user to browsing or expert.
Comment 14•25 years ago
|
||
this definitely falls into the category of good practice.
the only instance where it is going to really make a difference though is when
the user has opted for both "search" and "go" to appear on the toolbar. one of
them should be tied to the enter key, and that should be "go". so let's go
ahead and give it default appearance and close this bug.
the go vs. search discussion is a different matter.
| Assignee | ||
Comment 15•25 years ago
|
||
Updated•24 years ago
|
Attachment #57175 -
Flags: review+
Comment 16•24 years ago
|
||
Comment on attachment 57175 [details] [diff] [review]
patch to make "go" button look like default
r=walk84
Comment 17•24 years ago
|
||
Comment on attachment 57175 [details] [diff] [review]
patch to make "go" button look like default
sr=jag
Attachment #57175 -
Flags: superreview+
C:\moz_src\mozilla\xpfe\browser\resources\content>cvs commit -m "Bug
51985. 'Go' button should be styled as default. Patch by Bradley Hart
<bhart@cvip.net>. r=walk84/sr=jag" navigator.xul
Checking in navigator.xul;
/cvsroot/mozilla/xpfe/browser/resources/content/navigator.xul,v <--
navigator.xul
new revision: 1.376; previous revision: 1.375
done
C:\moz_src\mozilla\xpfe\browser\resources\content>
Assignee: ben → bhart
Status: ASSIGNED → NEW
Status: NEW → RESOLVED
Closed: 25 years ago → 24 years ago
Resolution: --- → FIXED
Marking fixed; I landed this on the trunk for Bradley.
| Assignee | ||
Comment 20•24 years ago
|
||
Thanks, I completely forgot about this bug...
Comment 21•22 years ago
|
||
VERIFIED:
Mac OS X 10.3.3, Mozilla 1.7RC2
classic + modern.
BTW, is the defaualt state in classic shown by being a blue-background button?
QA Contact: claudius → benc
Whiteboard: checkmac, checklinux
Updated•21 years ago
|
Product: Core → Mozilla Application Suite
You need to log in
before you can comment on or make changes to this bug.
Description
•