519974 - When we use IME, ASSERTION is printed at each key input (ASSERTION: nsEditor doesn't support wide caret: 'selectionStart == selectionEnd', editor/libeditor/base/IMETextTxn.cpp line 322

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

ASSERTION: nsEditor doesn't support wide caret: 'selectionStart == selectionEnd', editor/libeditor/base/IMETextTxn.cpp line 322

is printed at every key typing with IME.

I added the assertion in another bug. The assertion says that nsChildView send the wide caret setting by NS_TEXT_TEXT event. I'll fix this bug in bug 519972.

Note that this bug doesn't break any functions. It is just a warning for the widget developers.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I'll fix this bug soon.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v1.0

The caret end position must be same as its start position on Mac.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v1.0

sorry for the spam.

Comment 4

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 452640 [details] [diff] [review]
Patch v1.0

This makes sense to me.  I haven't tested it, but I assume it
shouldn't cause any problems.

Note that your change invalidates this comment:

  // Caret is indicator of insertion point, so mEndOffset = 0.

So it should also be changed.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

http://hg.mozilla.org/mozilla-central/rev/59a7a98a5a6b

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v1.0.1 (for check-in)