519987 - new Image() has wrong namespace URI

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix for those 4 callsites

There were 4 spots that bug 468708 missed: new Image(), new Audio(), setting .title on a document, and poster frames for videos.  Fixed on trunk as part of bug 488249, but I think we should fix them on the branch too.

We effectively have tests on trunk for this (because the frame constructor now uses namespace uris to create frames, so new Image() followed by insertion into the document wouldn't get an ImageFrame, but I can write a mochitest too before I check this in, if desired.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 404051 [details] [diff] [review]
Fix for those 4 callsites

Can you also add an assertion to the nsGenericHTMLElement ctor to assert that the XHTML namespace is used.

r=me with that.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/releases/mozilla-1.9.2/rev/50a7628372b9 to fix the bug

Pushed http://hg.mozilla.org/releases/mozilla-1.9.2/rev/db092a8a0b6f and http://hg.mozilla.org/mozilla-central/rev/6e8de7ff27b8 for the test and assert.