520092 - client.plugins should be an object (dictionary) not an array.

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, enhancement)

Comment 1

[:Gijs (he/him)]

Uh, Bugzilla sucks. Otherwise, see the summary.

Comment 2

[:Gijs (he/him)]

Attachment: Patch

This seems to work.

The only thing I'm not 100% sure about is if plugin prefs are migrated correctly like this. AFAICT they are stored by ID so there shouldn't be issues, but I could be wrong.

Comment 3

[James Ross]

Comment on attachment 619368 [details] [diff] [review]
Patch

Review of attachment 619368 [details] [diff] [review]:
-----------------------------------------------------------------

::: xul/content/commands.js
@@ +1974,1 @@
>      }

Nit: drop the for's braces.

@@ +2581,5 @@
>          if (typeof rv == "function")
>              rvStr = "function";
>  
> +        if (!plugin.id)
> +            plugin.id = 'plugin' + Date.now() + Math.floor(Math.random() * 100)

plugin.id = 'plugin' + randomString(8);

I guess you could use the time too, but I don't think it'd be necessary with 62^8 values.

::: xul/content/static.js
@@ +809,5 @@
>  function getPluginById(id)
>  {
> +    if (id in client.plugins) {
> +      return client.plugins[id];
> +    }

Nit: drop the if's braces (opening should be on a new line if kept too).

@@ +814,1 @@
>      return null;

Could collapse the entire function to: return client.plugins[id] || null; I think.

Comment 4

[:Gijs (he/him)]

Fix checked in with nits (and then some): http://hg.mozilla.org/chatzilla/rev/e3c672afa43c