520188 - make msaa role map conform for aria directory and marquee

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: patch

Currently we 'fail' on three mappings. I'm filing this so that we can have a patch ready to go if we agree that we should map these as per TPG's expectations.

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Note we considered marquee and timer 'weak roles' in bug 481114.

Comment 2

[alexander :surkov (:asurkov)]

David, any URL we are going to follow to? (Iirc, there were some discussion where I interested why marquee and etc aren't mapped to more specific role and there was some answer there. However I don't recall it :) )

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Actually it looks like Steve is happy enough that we expose the BSTR and we know have a full green column :)

I'd like to leave this open to remind me to discuss with the UIA TF. I'll post results here.

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

Heh, keep forgetting to post the link:
http://www.paciellogroup.com/blog/aria-tests/ARIA-SafariaOperaIEFF-update2.html

Comment 5

[Marco Zehe (:MarcoZ)]

If we do have numeric mappings for certain roles and they're the same as the BSTR, I think we should expose the numeric value so ATs don't have to cope with BSTR roles more than absolutely necessary.

Comment 6

[alexander :surkov (:asurkov)]

This makes sense but we need to figure out why implementation guide recommends BSTR usage (http://www.w3.org/TR/wai-aria-implementation/#mapping_role). Let's wait for David's discussion.

Comment 7

[David Bolter [:davidb] (NeedInfo me for attention)]

Alexander, I just noticed you are looking at an older document. The updated one is kept here: http://www.w3.org/WAI/PF/aria-implementation/

MS considers BSTR based roles an MSAA error (even though we have AT using them with FF). It looks like IE will expose these role mappings, so it is probably nicest for us to do this too.

Comment 8

[alexander :surkov (:asurkov)]

ARIA impl guide is still not updated to your patch ;) I see marque corresponds to impl guide only.

Comment 9

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to comment #8)
> ARIA impl guide is still not updated to your patch ;) I see marque corresponds
> to impl guide only.

Not sure I understand? I see ROLE_SYSTEM_ANIMATION in the impl guide and in the patch.

Comment 10

[alexander :surkov (:asurkov)]

Yeah, everything is ok with marque. I meant directory and timer.

Comment 11

[David Bolter [:davidb] (NeedInfo me for attention)]

Jamie, do you see any problems with this patch? We would have these 3 new aria->msaa mappings:
directory to list
marquee to animation
timer to clock

Comment 12

[David Bolter [:davidb] (NeedInfo me for attention)]

Previous to this patch, the role would be mapped from the underlying markup.

Comment 13

[James Teh [:Jamie]]

Sounds fine to me.

The only issue I see is that NVDA (and perhaps other ATs, but not sure) call ROLE_SYSTEM_CLOCK "clock". The only instance of this that I am aware of is the clock in the notification area/system tray. In cases where it isn't a real clock, this could be misleading. "Timer" might be a more correct label, but this will cause the clock to be called timer as well. Hmm. Anyway, I think this is an issue we'll need to sort out separately.

Comment 14

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: patch

We shouldn't map timer.

Comment 15

[alexander :surkov (:asurkov)]

Comment on attachment 421262 [details] [diff] [review]
patch


>+    "directory",
>+    nsIAccessibleRole::ROLE_LIST,
>+    kUseMapRole,

>   // nsIAccessibleRole::ROLE_DIRECTORY_PANE
>-  { USE_ROLE_STRING, IA2_ROLE_DIRECTORY_PANE },
>+  { ROLE_SYSTEM_LIST, IA2_ROLE_DIRECTORY_PANE },

>+  <div id="dir" role="directory">
>+    <div>A</div>
>+    <div>B</div>
>+    <div>C</div>
>+  </div>

list without listitems or directory pane?

Comment 16

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: map marquee to animation, and directory to list

Yeah the msaa change was bogus. Thanks.

Comment 17

[alexander :surkov (:asurkov)]

Comment on attachment 421269 [details] [diff] [review]
map marquee to animation, and directory to list

r=me, thanks

Comment 18

[David Bolter [:davidb] (NeedInfo me for attention)]

Landed on 1.9.3: http://hg.mozilla.org/mozilla-central/rev/0b60cf139fdc