520284 - Search should use the method for participating adding a timerManager timer implemented in bug 471219

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Robert Strong (they/them - no direct email)]

See Bug 471219 for details

Comment 1

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Patch

Comment 2

[Reed Loden [:reed]]

Comment on attachment 404406 [details] [diff] [review]
Patch

>+      var expirTime = engineMetadataService.getAttr(engine, "updateexpir");
>+      LOG("expirTime: " + expirTime + "\nupdateURL: " + engine._updateURL +
>+          "\niconUpdateURL: " + engine._iconUpdateURL);
>+
>+      var engineExpired = expirTime <= currentTime;
>+
>+      if (!expirTime || !engineExpired) {

I know you're just moving this code around, but could you please fix the gross misspelling of "expire"? Thanks. :)

Comment 3

[Ryan Flint [:rflint] (ping via IRC for reviews)]

(In reply to comment #2)
> I know you're just moving this code around, but could you please fix the gross
> misspelling of "expire"? Thanks. :)

It's more likely a truncated version of "expir(ation|y)" and is in line with the name of the metadata we store. I'll pass! :)

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 404406 [details] [diff] [review]
Patch

Looks good and thank!

Comment 5

[Robert Strong (they/them - no direct email)]

btw: the patch didn't apply cleanly but I did manually apply the rejected parts and verified all worked as expected.

Comment 6

[Ryan Flint [:rflint] (ping via IRC for reviews)]

http://hg.mozilla.org/mozilla-central/rev/0c8d99d73f09

(In reply to comment #5)
> btw: the patch didn't apply cleanly but I did manually apply the rejected parts
> and verified all worked as expected.

Oops, sorry - didn't think this had fallen victim to bitrot. Thanks for the review!