Search should use the method for participating adding a timerManager timer implemented in bug 471219

RESOLVED FIXED in Firefox 3.7a1

Status

()

Firefox
Search
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: rstrong, Assigned: rflint)

Tracking

Trunk
Firefox 3.7a1
Points:
---
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

See Bug 471219 for details
Depends on: 471219
Created attachment 404406 [details] [diff] [review]
Patch
Assignee: nobody → rflint
Status: NEW → ASSIGNED
Attachment #404406 - Flags: review?(gavin.sharp)
Comment on attachment 404406 [details] [diff] [review]
Patch

>+      var expirTime = engineMetadataService.getAttr(engine, "updateexpir");
>+      LOG("expirTime: " + expirTime + "\nupdateURL: " + engine._updateURL +
>+          "\niconUpdateURL: " + engine._iconUpdateURL);
>+
>+      var engineExpired = expirTime <= currentTime;
>+
>+      if (!expirTime || !engineExpired) {

I know you're just moving this code around, but could you please fix the gross misspelling of "expire"? Thanks. :)
(In reply to comment #2)
> I know you're just moving this code around, but could you please fix the gross
> misspelling of "expire"? Thanks. :)

It's more likely a truncated version of "expir(ation|y)" and is in line with the name of the metadata we store. I'll pass! :)
Attachment #404406 - Flags: review?(gavin.sharp) → review?(robert.bugzilla)
Comment on attachment 404406 [details] [diff] [review]
Patch

Looks good and thank!
Attachment #404406 - Flags: review?(robert.bugzilla) → review+
btw: the patch didn't apply cleanly but I did manually apply the rejected parts and verified all worked as expected.
http://hg.mozilla.org/mozilla-central/rev/0c8d99d73f09

(In reply to comment #5)
> btw: the patch didn't apply cleanly but I did manually apply the rejected parts
> and verified all worked as expected.

Oops, sorry - didn't think this had fallen victim to bitrot. Thanks for the review!
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
Version: 3.6 Branch → Trunk
You need to log in before you can comment on or make changes to this bug.