Closed
Bug 520284
Opened 14 years ago
Closed 14 years ago
Search should use the method for participating adding a timerManager timer implemented in bug 471219
Categories
(Firefox :: Search, defect)
Firefox
Search
Tracking
()
RESOLVED
FIXED
Firefox 3.7a1
People
(Reporter: robert.strong.bugs, Assigned: rflint)
References
Details
Attachments
(1 file)
10.12 KB,
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
See Bug 471219 for details
Assignee | ||
Comment 1•14 years ago
|
||
Comment 2•14 years ago
|
||
Comment on attachment 404406 [details] [diff] [review] Patch >+ var expirTime = engineMetadataService.getAttr(engine, "updateexpir"); >+ LOG("expirTime: " + expirTime + "\nupdateURL: " + engine._updateURL + >+ "\niconUpdateURL: " + engine._iconUpdateURL); >+ >+ var engineExpired = expirTime <= currentTime; >+ >+ if (!expirTime || !engineExpired) { I know you're just moving this code around, but could you please fix the gross misspelling of "expire"? Thanks. :)
Assignee | ||
Comment 3•14 years ago
|
||
(In reply to comment #2) > I know you're just moving this code around, but could you please fix the gross > misspelling of "expire"? Thanks. :) It's more likely a truncated version of "expir(ation|y)" and is in line with the name of the metadata we store. I'll pass! :)
Assignee | ||
Updated•14 years ago
|
Attachment #404406 -
Flags: review?(gavin.sharp) → review?(robert.bugzilla)
![]() |
Reporter | |
Comment 4•14 years ago
|
||
Comment on attachment 404406 [details] [diff] [review] Patch Looks good and thank!
Attachment #404406 -
Flags: review?(robert.bugzilla) → review+
![]() |
Reporter | |
Comment 5•14 years ago
|
||
btw: the patch didn't apply cleanly but I did manually apply the rejected parts and verified all worked as expected.
Assignee | ||
Comment 6•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/0c8d99d73f09 (In reply to comment #5) > btw: the patch didn't apply cleanly but I did manually apply the rejected parts > and verified all worked as expected. Oops, sorry - didn't think this had fallen victim to bitrot. Thanks for the review!
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
Version: 3.6 Branch → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•