Closed Bug 520368 Opened 11 years ago Closed 11 years ago
<menulist> Setting onchange Handler Does Not Fire
I wonder, does Fennec use menulist anywhere currently?
I'm already working on this, I have a WIP to fire oncommand on menulist but it sounds like the selectedIndex property is weird in our current implementation for menulist. (In reply to comment #1) > I wonder, does Fennec use menulist anywhere currently? Probably not, and I think menulist should not fire any onChange event, that are specific to HTML elements, but a oncommand one instead (which is not working actually). (In reply to comment #0) > I've tested with the sample codes, but without success. > > <setting type="control" title="Testing"> > <menulist onchange="Components.reportError('Hello');"> > <menupopup> > <menulist label="AAA"/> > <menulist label="BBB"/> > </menupopup> > </menulist> > </setting> These 2 nested menulist elements should be menuitem (this didn't resolved the error btw)
Assignee: nobody → 21
Status: UNCONFIRMED → NEW
Ever confirmed: true
* Replace the onchange handler by a oncommand handler * Remove the text nodes inserted cause of XMLHttpRequest (which are the cause of the errors that David saw in his console) * Correct a few errors in our SelectHelper implem
Get rid of the type getters
oups! Wrong patch! Sorry for the spam.
* handle command/oncommand/addEventListener/* for Menulist * handle onchange/addEventlistener/* for html:select This also resolved bug 519271 since we fire a onchange event now instead of manually calling the select.onchange method. I'm wondering if that's bad to dispatch a command event to every item? (imho : no)
Attachment #405270 - Flags: review?(mark.finkle) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → B5
You need to log in before you can comment on or make changes to this bug.