520369 - InstallTrigger.trigger returns incorrect status code

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[David McNamara [:mackers]]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.3) Gecko/20090824 Ant.com Toolbar 1.4 Firefox/3.1b2, Ant.com Toolbar 1.2
Build Identifier: 

Using InstallTrigger.trigger to install xpis to Fennec sometimes returns a status code for success (0) when, in fact, the install does not succeed.

I have seen this a couple of times, one such example of which being the Dom Inspector add-on.


Reproducible: Always

Comment 1

[David McNamara [:mackers]]

This is important form the perspective of the Add-ons Collector. This add-on attempts to automatically install add-ons from a feed during fennec startup.

If install fails (status code < 0), the add-on install is not attempted again.

In the case of the DOM Inspector above, the install appears to succeed, but is not in fact installed. This is a problem, because during the next restart, the add-on install will be attempted again, ad nausium.

There are no error messages in the console.

Comment 2

[Dave Townsend [:mossop]]

Do you mean InstallTrigger.install?

Do you have a short testcase that demonstrates this behaviour?

Comment 3

[Brian King [:kinger]]

(In reply to comment #2)
> Do you mean InstallTrigger.install?

Yes, I think so.

> Do you have a short testcase that demonstrates this behaviour?

We could put one together.

FYI, the code is at:

http://viewvc.svn.mozilla.org/vc/addons/trunk/bandwagon/content/ui/overlays/browserOverlayController.js?revision=52517&view=markup

Look for doAutoInstall

Comment 4

[BMO Automation]

Closing all opened bug in a graveyard component