[OS/2] build break due to typo

RESOLVED FIXED in mozilla1.9.3a1

Status

Core Graveyard
Widget: OS/2
--
blocker
RESOLVED FIXED
8 years ago
3 years ago

People

(Reporter: Dave Yeo, Assigned: Dave Yeo)

Tracking

Trunk
mozilla1.9.3a1
x86
OS/2
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(status1.9.2 beta3-fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9.1.4pre) Gecko/20090925 SeaMonkey/2.0pre
Build Identifier: 

The build is currently dying here,
I:/comm-central/.mozilla-trunk/widget/src/os2/nsWindow.cpp: In member function 'void nsWindow::DoCreate(HWND, nsWindow*, const nsIntRect&, nsEventStatus (*)(nsGUIEvent*), nsIDeviceContext*, nsIAppShell*, nsIToolkit*, nsWidgetInitData*)':
I:/comm-central/.mozilla-trunk/widget/src/os2/nsWindow.cpp:734: error: 'mBorerStyle' was not declared in this scope 

which looks like a simple typo.

Reproducible: Always

Steps to Reproduce:
1. Pull tree
2. attempt to build
3.
Actual Results:  
I:/comm-central/.mozilla-trunk/widget/src/os2/nsWindow.cpp: In member function 'void nsWindow::DoCreate(HWND, nsWindow*, const nsIntRect&, nsEventStatus (*)(nsGUIEvent*), nsIDeviceContext*, nsIAppShell*, nsIToolkit*, nsWidgetInitData*)':
I:/comm-central/.mozilla-trunk/widget/src/os2/nsWindow.cpp:734: error: 'mBorerStyle' was not declared in this scope 

Expected Results:  
The build to continue
(Assignee)

Comment 1

8 years ago
Created attachment 404472 [details] [diff] [review]
Correct the typo

Fix the typo
Attachment #404472 - Flags: review?
(Assignee)

Comment 2

8 years ago
I should add that tracing which bug introduced this has been unsuccessful. Looking at http://hg.mozilla.org/mozilla-central/file/a051d25333fc/widget/src/os2/nsWindow.cpp points to https://bugzilla.mozilla.org/show_bug.cgi?id=516701 which doesn't make sense. Almost seems that changeset a051d25333fc has been duplicated

Updated

8 years ago
Attachment #404472 - Flags: review? → review?(mozilla)

Updated

8 years ago
Blocks: 509693
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: unspecified → Trunk

Comment 3

8 years ago
Comment on attachment 404472 [details] [diff] [review]
Correct the typo

I can review this
Attachment #404472 - Flags: review?(mozilla) → review+

Comment 4

8 years ago
Thanks Mike. Dave I've set the checkin-needed flag to get building again
Severity: normal → major
Keywords: checkin-needed
(In reply to comment #2)
> http://hg.mozilla.org/mozilla-central/file/a051d25333fc/widget/src/os2/nsWindow.cpp
> points to https://bugzilla.mozilla.org/show_bug.cgi?id=516701 which doesn't

Not sure what you look at, but:
http://hg.mozilla.org/mozilla-central/annotate/a051d25333fc/widget/src/os2/nsWindow.cpp
correctly refers to
http://hg.mozilla.org/mozilla-central/rev/f3c07913015f
"Bug 509693. Remove eWindowType_java (unused) and actually use eWindowType_plugin. r=josh"
Assignee: mozilla → daveryeo
Severity: major → blocker
Status: NEW → ASSIGNED

Comment 6

8 years ago
http://hg.mozilla.org/mozilla-central/rev/93d2eef52108
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.3a1

Comment 7

8 years ago
Peter, any possibilities of yours to push it to 1.9.2?

Comment 8

8 years ago
Finally had access to a machine which can push:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/88ce6c86cbb3
status1.9.2: --- → final-fixed
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.