520420 - [OS/2] build break due to typo

Status: RESOLVED FIXED

(Core Graveyard :: Widget: OS/2, defect)

Description

[Dave Yeo]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9.1.4pre) Gecko/20090925 SeaMonkey/2.0pre
Build Identifier: 

The build is currently dying here,
I:/comm-central/.mozilla-trunk/widget/src/os2/nsWindow.cpp: In member function 'void nsWindow::DoCreate(HWND, nsWindow*, const nsIntRect&, nsEventStatus (*)(nsGUIEvent*), nsIDeviceContext*, nsIAppShell*, nsIToolkit*, nsWidgetInitData*)':
I:/comm-central/.mozilla-trunk/widget/src/os2/nsWindow.cpp:734: error: 'mBorerStyle' was not declared in this scope 

which looks like a simple typo.

Reproducible: Always

Steps to Reproduce:
1. Pull tree
2. attempt to build
3.
Actual Results:  
I:/comm-central/.mozilla-trunk/widget/src/os2/nsWindow.cpp: In member function 'void nsWindow::DoCreate(HWND, nsWindow*, const nsIntRect&, nsEventStatus (*)(nsGUIEvent*), nsIDeviceContext*, nsIAppShell*, nsIToolkit*, nsWidgetInitData*)':
I:/comm-central/.mozilla-trunk/widget/src/os2/nsWindow.cpp:734: error: 'mBorerStyle' was not declared in this scope 

Expected Results:  
The build to continue

Comment 1

[Dave Yeo]

Attachment: Correct the typo

Fix the typo

Comment 2

[Dave Yeo]

I should add that tracing which bug introduced this has been unsuccessful. Looking at http://hg.mozilla.org/mozilla-central/file/a051d25333fc/widget/src/os2/nsWindow.cpp points to https://bugzilla.mozilla.org/show_bug.cgi?id=516701 which doesn't make sense. Almost seems that changeset a051d25333fc has been duplicated

Comment 3

[Mike Kaply [:mkaply]]

Comment on attachment 404472 [details] [diff] [review]
Correct the typo

I can review this

Comment 4

[Walter Meinl]

Thanks Mike. Dave I've set the checkin-needed flag to get building again

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)
> http://hg.mozilla.org/mozilla-central/file/a051d25333fc/widget/src/os2/nsWindow.cpp
> points to https://bugzilla.mozilla.org/show_bug.cgi?id=516701 which doesn't

Not sure what you look at, but:
http://hg.mozilla.org/mozilla-central/annotate/a051d25333fc/widget/src/os2/nsWindow.cpp
correctly refers to
http://hg.mozilla.org/mozilla-central/rev/f3c07913015f
"Bug 509693. Remove eWindowType_java (unused) and actually use eWindowType_plugin. r=josh"

Comment 6

[Peter Weilbacher]

http://hg.mozilla.org/mozilla-central/rev/93d2eef52108

Comment 7

[Walter Meinl]

Peter, any possibilities of yours to push it to 1.9.2?

Comment 8

[Peter Weilbacher]

Finally had access to a machine which can push:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/88ce6c86cbb3