520432 - Personal vcard editing shouldn't have a "photo" tab.

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Vincent (caméléon)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.9.0.14) Gecko/2009090216 Ubuntu/9.04 (jaunty) Firefox/3.0.14
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.9.1.4pre) Gecko/20090915 Thunderbird/3.0b4

When you edit your personal vcard, there is a new tab called "photo", but this tab has no content.

Reproducible: Always

Steps to Reproduce:
1. Open your account settings
2. Edit your personal vcard
3. Go to the "photo" tab
Actual Results:  
no content into this tab

Expected Results:  
2 possibility:
- "photo" tab could be deleted has it has no content
OR
- The UI allowing to choose a photo should be displayed in this tab (has for a normal contact editing)

Comment 1

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

It's empty in Thunderbird because the patch in bug 119459 intended to punt on photos for vcards for now, but it did it by adding the tab content box to the list of things that are collapsed for vcards in Thunderbird, and not doing anything for SeaMonkey, where you get a perfectly usable (and ultimately useless since it doesn't go anywhere) photo tab. Instead, it should have meant to hide the whole tab, the same rather twisted way we only let you have the statutory one address by hiding the "Home" tab.

Comment 2

[Vincent (caméléon)]

Thanks for the feedback. 
From your comment, I understand that " Bug 247154 -  Inline vCard Editing UI Lacks Home Address Editing " will never be fixed. Is it right? Because some people (and me) still hope a fix (as the bug is mark "NEW"), so maybe an explanation is needed.

Comment 3

[Mark Banner (:standard8)]

(In reply to comment #2)
> Thanks for the feedback. 
> From your comment, I understand that " Bug 247154 -  Inline vCard Editing UI
> Lacks Home Address Editing " will never be fixed. Is it right? Because some
> people (and me) still hope a fix (as the bug is mark "NEW"), so maybe an
> explanation is needed.

Your assumptions are incorrect. The only time a bug will *never* be fixed is if it gets marked as WONTFIX.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 404556 [details] [diff] [review]
Fix v.1

/me sighs. We always forget the vcard dialog :-(

Comment 5

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/11eb8c57e700

Comment 6

[Renato S. Yamane]

There is no tab called "Photo" on Thunderbird 24.6.0

Only "General", "Work" and "Other".

How is possible add a photo on vcard?