520447 - Saving broken in "Page Info" and "View Source"

Status: RESOLVED FIXED

(SeaMonkey :: Page Info, defect)

Description

[Adrian Buckley]

Can no longer save media using the Page Info "Media" tab or "Save Page as" in "View Source".

Error console reports:

Error: document.getElementById("contentAreaCommandsBundle") is null
Source File: chrome://communicator/content/contentAreaUtils.js
Line: 578

Comment 1

[Serge Gautherie (:sgautherie)]

Not sure where your line number comes from:

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.3a1pre) Gecko/20090928 SeaMonkey/2.1a1pre] (nightly) (W2Ksp4)
{
Error: document.getElementById("contentAreaCommandsBundle") is null
Source File: chrome://communicator/content/contentAreaUtils.js
Line: 596
}

Comment 2

[Serge Gautherie (:sgautherie)]

http://mxr.mozilla.org/comm-central/search?string=contentAreaUtils.js&case=on&find=%2Fsuite%2F
The (missed in bug 445831) issue is that (1+)3 files include contentAreaUtils.js directly (instead of through contentAreaContextOverlay.xul):
*pageInfo.xul and viewSourceOverlay.xul, indeed !
*test_contentAreaUtils.js, which doesn't care about the string bundle, atm.

A simple hack might be to copy and paste the bundle definition in these 2 xul files!?

Another solution should be to revert part of what was done in bug 445831: see bug 475283 comment 8...
And if we do that, I wonder if this function should move to nsISuiteGlue.idl?
Ftr,
http://mxr.mozilla.org/comm-central/search?string=contentAreaCommandsBundle&case=on&find=%2Fsuite%2Fcommon%2F

Comment 3

[[e-mail]]

(In reply to comment #2)
> A simple hack might be to copy and paste the bundle definition in these 2 xul files!?
Plus a comment, of course ;-)

Comment 4

[[e-mail]]

Plus one in contentAreaUtils.js, I guess.

Comment 5

[Philip Chee]

Attachment: Patch v1.0

>> A simple hack might be to copy and paste the bundle definition in these 2 xul files!?
> Plus a comment, of course ;-)
> Plus one in contentAreaUtils.js, I guess.
Patch as suggested.

Comment 6

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) Add 2 missing 'contentAreaCommandsBundle' declarations and related comments, s/x-javascript/javascript/g, Whitespace++ cleanup [Checkin: See comment 11]

Arf, I was working on it too...
I copied the main comment from Philip's patch ;-)

Comment 7

[Philip Chee]

Sorry Serge, I waited for a while but nobody took the bug. And didn't Neil say to do whitespace clean-ups in separate patches?

Comment 8

[Serge Gautherie (:sgautherie)]

(In reply to comment #7)

> Sorry Serge, I waited for a while but nobody took the bug.

No problem.

> And didn't Neil say to do whitespace clean-ups in separate patches?

Probably: well, I could split this one in two before checkin if wanted...

Comment 9

[[e-mail]]

Comment on attachment 404618 [details] [diff] [review]
(Bv1) Add 2 missing 'contentAreaCommandsBundle' declarations and related comments, s/x-javascript/javascript/g, Whitespace++ cleanup
[Checkin: See comment 11]

>-  // Where appropiate we want to pass the charset of the 
>+  // Where appropiate we want to pass the charset of the
The problem with unrelated whitespace fixes is that you also have to check for spelling errors too ;-)

Comment 10

[[e-mail]]

Comment on attachment 404613 [details] [diff] [review]
Patch v1.0

I'll r+ this too in case the powers that be prefer to approve this version ;-)

Comment 11

[Serge Gautherie (:sgautherie)]

Comment on attachment 404618 [details] [diff] [review]
(Bv1) Add 2 missing 'contentAreaCommandsBundle' declarations and related comments, s/x-javascript/javascript/g, Whitespace++ cleanup
[Checkin: See comment 11]


http://hg.mozilla.org/comm-central/rev/524c027b000a
Bv1, with comment 9 suggestion(s).