520622 - use windows style paths for windows mobile build

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

PyMake currently doesn't handle msys paths well.

Comment 1

[(not currently active) Ted Mielczarek]

Comment on attachment 404679 [details] [diff] [review]
patch

-_topsrcdir=`cd \`dirname $0\`; pwd`
-_objdir=`pwd`
+case "$target" in 
+*-wince*)
+    _topsrcdir=`cd \`dirname $0\`; pwd -W`
+    _objdir=`pwd -W`
+    ;;

I don't think this is necessary. $_objdir isn't really used anywhere important, and $_topsrcdir is only used in one place, AFAICT. I'd just get yourself a $_topsrcdirwin here, where it's actually used:
     make OGLES_SDK_DIR="$OGLES_SDK_DIR" WINCE_SDK_DIR="$WINCE_SDK_DIR" TOPSRCDIR="$_topsrcdir" OBJDIR="$_pwdw" -C $srcdir/build/wince/tools

     _pwdw=`pwd -W`
-    _pwd=`pwd`
+    _pwd=`pwd -W`

This seems silly. Just drop $_pwdw here, make $_pwd be the windows-style path, and make everything use it. Everything handles these forward-slash Windows paths just fine, AFAIK.

         CYGWIN_WRAPPER="${srcdir}/build/cygwin-wrapper"
         if test "`echo ${srcdir} | grep -c ^/ 2>/dev/null`" = 0; then
-            _pwd=`pwd`
+            _pwd=`pwd -W`
             CYGWIN_WRAPPER="${_pwd}/${srcdir}/build/cygwin-wrapper"

You don't want to change this. This is strictly for Cygwin support. (We should just drop that at some point.)

r=me with those changes.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/0316ea5adbe1

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 404679 [details] [diff] [review]
patch

a192=beltzner

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/releases/mozilla-1.9.2/rev/181296bbc9c2