520666 - chromium IPC should support char, unsigned char

Status: RESOLVED INCOMPLETE

(Core :: IPC, defect, P5)

Description

[Joe Drew (not getting mail)]

Attachment: char support

Currently the chromium IPC layer doesn't support serializing char or unsigned char. It should!

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 404720 [details] [diff] [review]
char support

>diff --git a/ipc/chromium/src/chrome/common/ipc_message_utils.h b/ipc/chromium/src/chrome/common/ipc_message_utils.h
>--- a/ipc/chromium/src/chrome/common/ipc_message_utils.h
>+++ b/ipc/chromium/src/chrome/common/ipc_message_utils.h
>@@ -144,16 +144,52 @@ struct ParamTraits<bool> {
> template <>
>+struct ParamTraits<char> {
[snip]
>+  static void Log(const param_type& p, std::wstring* l) {
>+    l->append(StringPrintf(L"%hd", p));
>+  }
>+};

Minor nit: IMHO it makes more sense to log |char|s as |"'%c'"|.  (And I agree that |"%hd"| makes sense for |unsigned char|.)

r+ with or without that change.

Comment 2

[Andrew McCreight [:mccr8]]

If somebody wants this, they should probably file a new bug.